-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tomcat jars to version greater than 9.0.75 #7713
Conversation
Suggested tests to cover this Pull Request
|
24452dc
to
67bcd93
Compare
67bcd93
to
3d810d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm, it seems the version intervals are not working properly (at least using apache-ivy-2.5.2-2.1.noarch
):
[ivy-retrieve] ::::::::::::::::::::::::::::::::::::::::::::::
[ivy-retrieve] :: UNRESOLVED DEPENDENCIES ::
[ivy-retrieve] ::::::::::::::::::::::::::::::::::::::::::::::
[ivy-retrieve] :: suse#jasper;[9.0.75,10.0.0[: not found
[ivy-retrieve] :: suse#jasper-el;[9.0.75,10.0.0[: not found
[ivy-retrieve] :: suse#tomcat-el-3.0-api;[9.0.75,10.0.0[: not found
[ivy-retrieve] :: suse#tomcat-jsp-2.3-api;[9.0.75,10.0.0[: not found
[ivy-retrieve] :: suse#tomcat-juli;[9.0.75,10.0.0[: not found
[ivy-retrieve] :: suse#tomcat-servlet-4.0-api;[9.0.75,10.0.0[: not found
[ivy-retrieve] ::::::::::::::::::::::::::::::::::::::::::::::
[ivy-retrieve]
Not sure if I'm missing something..
Thanks for testing it, it was working in my case...I l have another look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woops, sorry! This is actually working fine!
I was using org="suse"
instead of org="manager-43"
when testing this on my Manager-4.3
branch.
Sorry for the noise. LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
What does this PR change?
According to https://ant.apache.org/ivy/history/2.5.2/ivyfile/dependency.html update tomcat jars to version greater than 9.0.75 (but lower than 10.0.0).
GUI diff
No difference.
Documentation
No documentation needed
DONE
Test coverage
No tests
DONE
Links
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test
(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run: