Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a few Sonarcloud issues in AuditManager #7729

Merged
merged 2 commits into from
Nov 27, 2023
Merged

Fix a few Sonarcloud issues in AuditManager #7729

merged 2 commits into from
Nov 27, 2023

Conversation

cbosdo
Copy link
Contributor

@cbosdo cbosdo commented Oct 20, 2023 •
edited by galaxy-ci
Loading

What does this PR change?

Fix https://sonarcloud.io/project/issues?open=AYsd0cnIhCuKbzRvZ3mK&id=uyuni-project_uyuni as well as a few other sonarcloud reported issues in AuditManager.

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed: only internal and user invisible changes

  • DONE

Test coverage

  • No tests: already covered

  • DONE

Links

Fixes #
Tracks # add downstream PR, if any

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

@cbosdo cbosdo requested a review from a team as a code owner October 20, 2023 13:41
@cbosdo cbosdo requested review from parlt91 and removed request for a team October 20, 2023 13:41
@github-actions
Copy link
Contributor

👋 Hello! Thanks for contributing to our project 😄
☕ Acceptance tests will take same time (aprox. 1h)
👀 Once tests finish, you can check the cucumber report.
See the troubleshooting guide if you need any help.
⚠️ You should not merge if acceptance tests fail to pass
Happy hacking

@github-actions
Copy link
Contributor

Suggested tests to cover this Pull Request
  • minssh_salt_install_package
  • min_deblike_monitoring
  • srv_power_management
  • min_salt_mgrcompat_state
  • srv_sync_channels
  • proxy_cobbler_pxeboot
  • allcli_software_channels_dependencies
  • srv_content_lifecycle
  • minkvm_guests
  • srv_task_status_engine
  • srv_patches_page
  • srv_logfile
  • srv_rename_hostname
  • srv_docker_cve_audit
  • srv_enable_sync_products
  • srv_create_repository
  • srv_cobbler_profile
  • min_empty_system_profiles
  • min_ansible_control_node
  • srv_reportdb
  • min_retracted_patches
  • srv_add_rocky8_repositories
  • srv_organization_credentials
  • allcli_reboot
  • min_bootstrap_ssh_key
  • min_deblike_salt_install_package
  • buildhost_docker_build_image
  • minssh_bootstrap_api
  • srv_advanced_search
  • srv_cobbler_distro
  • srv_scc_user_credentials
  • min_rhlike_ssh
  • allcli_update_activationkeys
  • srv_datepicker
  • min_salt_openscap_audit
  • srv_change_password
  • srv_user_preferences
  • srv_cobbler_sync
  • min_salt_install_with_staging
  • allcli_config_channel
  • min_salt_software_states
  • srv_channels_add
  • min_bootstrap_api
  • min_bootstrap_reactivation
  • min_rhlike_monitoring
  • srv_distro_cobbler
  • min_rhlike_salt_install_package_and_patch
  • buildhost_osimage_build_image
  • srv_group_union_intersection
  • allcli_action_chain
  • min_salt_pkgset_beacon
  • buildhost_bootstrap
  • proxy_branch_network
  • min_cve_id_new_syntax
  • allcli_sanity
  • min_deblike_ssh
  • srv_check_channels_page
  • srv_dist_channel_mapping
  • min_config_state_channel
  • srv_change_task_schedule
  • min_salt_minions_page
  • srv_delete_channel_with_tool
  • srv_notifications
  • min_deblike_remote_command
  • sle_ssh_minion
  • srv_salt
  • min_custom_pkg_download_endpoint
  • allcli_software_channels
  • srv_maintenance_windows
  • sle_minion
  • srv_cobbler_buildiso
  • minssh_move_from_and_to_proxy
  • srv_users
  • srv_push_package
  • min_docker_api
  • srv_check_sync_source_packages
  • allcli_system_group
  • srv_handle_config_channels_with_ISS_v2
  • srv_delete_channel_from_ui
  • srv_restart
  • srv_power_management_redfish
  • srv_user_configuration_salt_states
  • min_bootstrap_negative
  • min_activationkey
  • srv_clone_channel_npn
  • min_rhlike_salt
  • min_salt_formulas_advanced
  • srv_handle_software_channels_with_ISS_v2
  • srv_manage_channels_page
  • srv_mainpage
  • min_salt_migration
  • min_recurring_action
  • proxy_as_pod_basic_tests
  • min_salt_minion_details
  • min_salt_lock_packages
  • min_deblike_openscap_audit
  • srv_check_reposync
  • min_check_patches_install
  • min_virthost
  • srv_power_management_api
  • min_move_from_and_to_proxy
  • min_project_lotus
  • min_config_state_channel_subscriptions
  • srv_payg_ssh_connection
  • min_timezone
  • min_salt_user_states
  • srv_activationkey_api
  • min_deblike_salt
  • srv_monitoring
  • min_deblike_salt_install_with_staging
  • min_cve_audit
  • min_rhlike_remote_command
  • srv_channel_api
  • proxy_retail_pxeboot_and_mass_import
  • min_bootstrap_script
  • min_rhlike_openscap_audit
  • srv_docker_advanced_content_management
  • srv_salt_download_endpoint
  • proxy_register_as_minion_with_script
  • min_salt_install_package
  • srv_menu
  • min_monitoring
  • min_change_software_channel
  • min_action_chain
  • srv_osimage
  • srv_first_settings
  • minssh_action_chain
  • srv_create_activationkey
  • min_salt_formulas
  • allcli_overview_systems_details
  • srv_disable_local_repos_off
  • min_ssh_tunnel

@cbosdo cbosdo force-pushed the sonar-fixes branch 2 times, most recently from 3960957 to cb42844 Compare October 20, 2023 15:36
@uyuni-project uyuni-project deleted a comment from github-actions bot Nov 13, 2023
@uyuni-project uyuni-project deleted a comment from github-actions bot Nov 13, 2023
@cbosdo cbosdo force-pushed the sonar-fixes branch 2 times, most recently from f3a07d0 to cffe469 Compare November 15, 2023 08:13
@uyuni-project uyuni-project deleted a comment from github-actions bot Nov 15, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 15, 2023 •
edited
Loading

👋 Hello! Thanks for contributing to our project.
Acceptance tests will take some time (aprox. 1h), please be patient ☕
You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/7729/checks
Once tests finish, if they fail, you can check 👀 the cucumber report. See the link at the output of the action.
You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/7729/checks.

If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code.

Reference tests:

For more tips on troubleshooting, see the troubleshooting guide.

Happy hacking!
⚠️ You should not merge if acceptance tests fail to pass. ⚠️

@rjpmestre rjpmestre self-requested a review November 15, 2023 12:22
@cbosdo cbosdo force-pushed the sonar-fixes branch 8 times, most recently from 4b638bb to 5f74bb9 Compare November 22, 2023 10:34
@cbosdo cbosdo force-pushed the sonar-fixes branch 2 times, most recently from 979a802 to ba38657 Compare November 23, 2023 15:21
@cbosdo
Copy link
Contributor Author

cbosdo commented Nov 24, 2023

@parlt91 could you have a look at this PR to unblock it now that all tests are green?

mikeletux
mikeletux approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@mikeletux mikeletux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just pointed out one small thing, but apart from that, looks good to me. Thanks @cbosdo !

java/code/src/com/redhat/rhn/common/util/FileUtils.java Outdated Show resolved Hide resolved
@cbosdo
Fix a few Sonarcloud issues in AuditManager
b87e82d
@cbosdo
Ensure the machine name is valid in AuditManager
a0463f8 
Checking that the resolved host path is in the expected folder ensures
no malicious machineName parameter can get us to list folder that
shouldn't be listed.
parlt91
parlt91 approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@parlt91 parlt91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cbosdo cbosdo merged commit c2513b5 into uyuni-project:master Nov 27, 2023
14 checks passed
@cbosdo cbosdo deleted the sonar-fixes branch November 27, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeletux mikeletux mikeletux approved these changes

@parlt91 parlt91 parlt91 approved these changes

@rjpmestre rjpmestre rjpmestre approved these changes

Assignees
No one assigned
Labels
API java_lint_checkstyle java_pgsql_tests java old-ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cbosdo @mikeletux @parlt91 @rjpmestre