Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the problem with the full package name of the proxy helm chart when tagging with tito #7813

Conversation

avshiliaev
Copy link
Contributor

What does this PR change?

In the following PR #7620 the name of the proxy helm chart was changed from proxy-helm to proxy. While the change is logical in itself, it creates errors when tagging the package with tito. In general, there're several things relevant for tito when tagging a package:

  • its name in the .spec file (Chart.yml in case of a helm chart)
  • the name of the .changes file in the package's dir
  • the name on the rel-eng/pacakges/
  • previous tags for this package

So the solution would be to either change all four parameters to proxy instead of proxy-helm here in git and only add the suffix when pushing to obs, or revert back to proxy-helm.

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed: only internal and user invisible changes

  • DONE

Test coverage

  • Not tested

  • DONE

Links

Fixes #
Tracks # add downstream PR, if any

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

@avshiliaev avshiliaev self-assigned this Nov 2, 2023
@avshiliaev avshiliaev requested a review from a team as a code owner November 2, 2023 14:55
@deneb-alpha
Copy link
Contributor

@juliogonzalez the PR looks good to me and it should solve the issue while tagging, but I would like to have a second check from you.

Copy link
Contributor

@deneb-alpha deneb-alpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deneb-alpha deneb-alpha merged commit 2b6c822 into uyuni-project:master Nov 2, 2023
6 checks passed
@avshiliaev avshiliaev deleted the revert-helm-proxy-package-name-for-tito-tagging branch October 16, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants