Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Credentials hierarchy - Additional fixes #8076

Merged
merged 2 commits into from
Dec 21, 2023

Conversation

mackdk
Copy link
Contributor

@mackdk mackdk commented Dec 21, 2023

What does this PR change?

This PR fixes the sql scripts idempotency and adds the missing changelogs.

Please note that the fix is up to the database schema 4.3.0, if the idempotency test is started from an earlier version, it might still fail. Currently, our tooling is using 4.3.8 as starting point.

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed: only internal and user invisible changes

  • DONE

Test coverage

  • No tests: No code change

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

@mackdk
Copy link
Contributor Author

mackdk commented Dec 21, 2023

I run manually locally susemanager-utils/testing/automation/schema-migration-test-pgsql.sh and susemanager-utils/testing/automation/schema-migration-test-pgsql.sh -P SUSE-Manager, both works now

Copy link
Contributor

@mcalmer mcalmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also did a local run. Looks good

@mackdk mackdk merged commit 20d698a into uyuni-project:master Dec 21, 2023
13 checks passed
@mackdk mackdk deleted the credentials-hierarchy-fixes branch December 21, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants