Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change org for orphan vendor packages via taskomatic #8097

Conversation

mcalmer
Copy link
Contributor

@mcalmer mcalmer commented Jan 4, 2024

What does this PR change?

When vendor packages were removed from a repo, they become orphan but cannot be removed by an admin as long as they are not belong to an organization.
To solve this, a org change statement was added to reposync.
This had some side effects when a package moved from one repo to another as it become first orphan, change the org and when it appears in the new repo it does not match the org and is downloaded and created again.

This PR move the functionality to taskomatic and it should be executed only once per day.

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed: only internal and user invisible changes

  • DONE

Test coverage

  • No tests: already covered

  • DONE

Links

Issue(s): https://github.com/SUSE/spacewalk/issues/22944
Ports(s): https://github.com/SUSE/spacewalk/pull/23334

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

Copy link
Contributor

github-actions bot commented Jan 4, 2024

👋 Hello! Thanks for contributing to our project.
Acceptance tests will take some time (aprox. 1h), please be patient ☕
You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/8097/checks
Once tests finish, if they fail, you can check 👀 the cucumber report. See the link at the output of the action.
You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/8097/checks.

If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code.

Reference tests:

KNOWN ISSUES

Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience.

For more tips on troubleshooting, see the troubleshooting guide.

Happy hacking!
⚠️ You should not merge if acceptance tests fail to pass. ⚠️

Copy link
Contributor

github-actions bot commented Jan 4, 2024

Suggested tests to cover this Pull Request

@mcalmer mcalmer force-pushed the change-org-for-orphen-vendor-packages-via-taskomatic branch from 3d7eb5e to 91947f5 Compare January 4, 2024 14:31
@mcalmer mcalmer requested a review from mikeletux January 4, 2024 14:33
@mcalmer mcalmer changed the title Change org for orphen vendor packages via taskomatic Change org for orphan vendor packages via taskomatic Jan 4, 2024
@mcalmer mcalmer requested review from mackdk and agraul January 8, 2024 11:08
@mcalmer mcalmer force-pushed the change-org-for-orphen-vendor-packages-via-taskomatic branch 2 times, most recently from 104f2ab to 5dac234 Compare January 18, 2024 13:20
Copy link
Contributor

@vzhestkov vzhestkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like such python code cleanups :-) 👍

Copy link
Contributor

@m-czernek m-czernek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving a few nit comments, please consider them before moving with the PR

Copy link
Contributor

@m-czernek m-czernek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it, much better! Esp. the DAILY_JOB_START/END variables are really clear now. TYVM!

@mcalmer mcalmer force-pushed the change-org-for-orphen-vendor-packages-via-taskomatic branch from 3b8130d to 5c20989 Compare January 25, 2024 09:56
@mcalmer mcalmer merged commit 4accf23 into uyuni-project:master Jan 25, 2024
22 checks passed
@mcalmer mcalmer deleted the change-org-for-orphen-vendor-packages-via-taskomatic branch January 25, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants