-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change org for orphan vendor packages via taskomatic #8097
Change org for orphan vendor packages via taskomatic #8097
Conversation
👋 Hello! Thanks for contributing to our project. If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code. Reference tests: KNOWN ISSUES Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience. For more tips on troubleshooting, see the troubleshooting guide. Happy hacking! |
Suggested tests to cover this Pull Request |
3d7eb5e
to
91947f5
Compare
104f2ab
to
5dac234
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like such python code cleanups :-) 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving a few nit comments, please consider them before moving with the PR
java/code/src/com/redhat/rhn/taskomatic/task/PackageCleanup.java
Outdated
Show resolved
Hide resolved
java/code/src/com/redhat/rhn/taskomatic/task/PackageCleanup.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it, much better! Esp. the DAILY_JOB_START/END
variables are really clear now. TYVM!
3b8130d
to
5c20989
Compare
What does this PR change?
When vendor packages were removed from a repo, they become orphan but cannot be removed by an admin as long as they are not belong to an organization.
To solve this, a org change statement was added to reposync.
This had some side effects when a package moved from one repo to another as it become first orphan, change the org and when it appears in the new repo it does not match the org and is downloaded and created again.
This PR move the functionality to taskomatic and it should be executed only once per day.
GUI diff
No difference.
Documentation
No documentation needed: only internal and user invisible changes
DONE
Test coverage
No tests: already covered
DONE
Links
Issue(s): https://github.com/SUSE/spacewalk/issues/22944
Ports(s): https://github.com/SUSE/spacewalk/pull/23334
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test
(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:
Before you merge
Check How to branch and merge properly!