QE: handle errors occurring during a page reload

[NamelessOne91]

What does this PR change?

Introduce a reusable function to reload pages and handle the case in which a TimeoutError is raised during a page reload, resulting in no screenshot being available for a failed scenario.

GUI diff

No difference.

• DONE

Documentation

• No documentation needed: only internal and user invisible changes

• DONE

Test coverage

• Cucumber tests were edited

• DONE

Links

Issue(s): https://github.com/SUSE/spacewalk/issues/22208
Backport Manager 4.3: https://github.com/SUSE/spacewalk/pull/23602

• DONE

Changelogs

• No changelog needed

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

• Re-run test "changelog_test"
• Re-run test "backend_unittests_pgsql"
• Re-run test "java_pgsql_tests"
• Re-run test "schema_migration_test_pgsql"
• Re-run test "susemanager_unittests"
• Re-run test "javascript_lint"
• Re-run test "spacecmd_unittests"

[github-actions]

👋 Hello! Thanks for contributing to our project.
Acceptance tests will take some time (aprox. 1h), please be patient ☕
You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/8110/checks
Once tests finish, if they fail, you can check 👀 the cucumber report. See the link at the output of the action.
You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/8110/checks.

If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code.

Reference tests:

• https://github.com/uyuni-project/uyuni/actions/workflows/acceptance_tests_secondary_parallel.yml?query=event%3Aschedule

• https://github.com/uyuni-project/uyuni/actions/workflows/acceptance_tests_secondary.yml?query=event%3Aschedule

KNOWN ISSUES

Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience.

For more tips on troubleshooting, see the troubleshooting guide.

Happy hacking!
⚠️ You should not merge if acceptance tests fail to pass. ⚠️

[maximenoel8]

Thanks for the effort Paolo. It will improve drastically our comfort of life to have this screenshot back !

[NamelessOne91]

I don't like the catching and re-throwing of errors but ATM it should to the work and avoid introducing further complexity in repeat_until_timeout

[Bischoff]

just one noobish question

[srbarrios]

Maybe instead of waiting here, we should be waiting in the After method, just before we take the screenshot.

But in any case, we are already waiting some time before taking any screenshots, probably even too much...!

https://github.com/uyuni-project/uyuni/blob/master/testsuite/features/support/env.rb#L138

As we are waiting twice the default_max_wait_time.

If we look at has_content APIDoc:
https://www.rubydoc.info/github/jnicklas/capybara/master/Capybara%2FNode%2FMatchers:has_content

@nodeg FYI ^

[NamelessOne91]

Right, it's much better indeed to have this kind of stuff in the After method.

Regarding the waits: when the failure happens in cases where we are not dealing with bootstrapping minions (as when checking the events history), this and condition will probably short circuit due to lazy evaluation.

click_button('Details') if has_content?('Bootstrap Minions') && has_content?('Details')

Maybe we can check for the exception which lead to a failure and use it to determine whether to force another wait, or not.
Something like:

find('#page-body', wait: 3) if scenario.exception.is_a?(TimeoutError)

Assuming the problem is actually not having enough time for the page to load.

[maximenoel8]

Hi @NamelessOne91 , what is the status of this PR?
It will help a lot to have it in uyuni and spacewalk to help debugging when we hit the timeout !

[NamelessOne91]

Hi @NamelessOne91 , what is the status of this PR? It will help a lot to have it in uyuni and spacewalk to help debugging when we hit the timeout !

Hi @maximenoel8
I've focused on fixing other testsuite issues or flaky tests lately, this PR has been on hold for a while.

I'm not sure the issue is just not having enough time to reload the page before a screenshot is taken, see Oscar's comment.
We can still try to implement an additional wait, in the After method, when a scenario failed due to a TimeoutError and see if that makes things better.,

[srbarrios]

Once Rubocop issue is fixed, LGTM.