-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the reference label in container images #8144
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few comments
containers/hub-xmlrpc-api-image/hub-xmlrpc-api.changes.cbosdonnat.versions-fix
Show resolved
Hide resolved
a3ef1a3
to
d7e4fc4
Compare
Fixed! thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, LGTM now
@cbosdo there's one extra image on Head that is missing here |
d7e4fc4
to
0711548
Compare
Fixed: we definitely need it |
I closed my PR in favor of this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a comment
containers/server-migration-14-16-image/.cbosdonnat.versions-fix
Outdated
Show resolved
Hide resolved
containers/server-migration-14-16-image/server-migration-14-16-image.changes
Outdated
Show resolved
Hide resolved
The reference label value needs to match the build tag and then contain the product version. The ARG PRODUCT_VERSION is appended when pushing the image to OBS.
0711548
to
358913d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, Cedric! 🚀
|
What does this PR change?
The reference label value needs to match the build tag and then contain the product version.
The ARG PRODUCT_VERSION is appended when pushing the image to OBS.
Links
Issue(s): https://github.com/SUSE/spacewalk/issues/22011
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test
(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:
Before you merge
Check How to branch and merge properly!