Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the reference label in container images #8144

Merged
merged 3 commits into from
Jan 12, 2024

Conversation

cbosdo
Copy link
Contributor

@cbosdo cbosdo commented Jan 11, 2024

What does this PR change?

The reference label value needs to match the build tag and then contain the product version.

The ARG PRODUCT_VERSION is appended when pushing the image to OBS.

Links

Issue(s): https://github.com/SUSE/spacewalk/issues/22011

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

Copy link
Contributor

@deneb-alpha deneb-alpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments

@cbosdo
Copy link
Contributor Author

cbosdo commented Jan 11, 2024

I left a few comments

Fixed! thanks

Copy link
Contributor

@deneb-alpha deneb-alpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, LGTM now

@deneb-alpha
Copy link
Contributor

@cbosdo there's one extra image on Head that is missing here server-migration-14-16-image. I'm adding a note here because I don't know if we need to release it with 5.0 or no

@cbosdo
Copy link
Contributor Author

cbosdo commented Jan 12, 2024

@cbosdo there's one extra image on Head that is missing here server-migration-14-16-image. I'm adding a note here because I don't know if we need to release it with 5.0 or no

Fixed: we definitely need it

@deneb-alpha
Copy link
Contributor

@cbosdo there's one extra image on Head that is missing here server-migration-14-16-image. I'm adding a note here because I don't know if we need to release it with 5.0 or no

Fixed: we definitely need it

I closed my PR in favor of this

Copy link
Contributor

@deneb-alpha deneb-alpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a comment

The reference label value needs to match the build tag and then
contain the product version.

The ARG PRODUCT_VERSION is appended when pushing the image to OBS.
Copy link
Contributor

@deneb-alpha deneb-alpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

Copy link
Contributor

@avshiliaev avshiliaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Cedric! 🚀

@deneb-alpha deneb-alpha merged commit f6ea17d into uyuni-project:master Jan 12, 2024
15 of 16 checks passed
Copy link
Contributor

⚠️ No changelog entry has been added. @cbosdo, please add necessary changelog entries with an additional PR.

@cbosdo cbosdo deleted the containers-tagging branch January 13, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants