Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable aarch64 builds for susemanager-branding-oss for SUSE Manager #8164

Merged

Conversation

juliogonzalez
Copy link
Member

@juliogonzalez juliogonzalez commented Jan 15, 2024

What does this PR change?

This package is not needed for Uyuni, so we keep it disabled.

It requires @deneb-alpha to fix product definitions for the upper case, and so they generate 5.0 release packages.

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed: There should be another card to do the doc for other architectures.

  • DONE

Test coverage

  • No tests: We build the package and have monitor jobs for this.

  • DONE

Links

Issue(s): https://github.com/SUSE/spacewalk/issues/22011

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

@deneb-alpha
Copy link
Contributor

my SR for the 000product is on its way. Currently building

@deneb-alpha
Copy link
Contributor

my SR for the 000product is on its way. Currently building

https://build.suse.de/request/show/317921

Copy link
Contributor

@deneb-alpha deneb-alpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deneb-alpha deneb-alpha merged commit bec51a3 into uyuni-project:master Jan 15, 2024
17 checks passed
@juliogonzalez juliogonzalez deleted the branding-oss-susemanager-5.0 branch January 15, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants