preflight.sh: Fix REPO_PORT condition syntax #8165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodeg
approved these changes
Jan 15, 2024
NamelessOne91
approved these changes
Jan 15, 2024
agraul
added
merge-candidate
In Bash, the string to the right of the =~ operator is interpreted as a POSIX extended regular expression. A quoted expression is matched literally, therefore we can't quote the string on the right side. Other than that, there were a few slips (redirection, missing "fi", missing "+" in regex)
agraul
force-pushed
the
fix-preflight-script-syntax
branch
from
dd81ac3
to
53a434e
Compare
srbarrios
approved these changes
Jan 15, 2024
m-czernek
pushed a commit
to m-czernek/uyuni
that referenced
this pull request
May 28, 2024
* preflight.sh: write selinux policy if needed SSH Push in the "tunnel" flavor can conflict with SELinux policies shipped by operating systems. The default policies are not aware of the additional port we need for the tunnel. The preflight.sh script is executed at the beginning of bootstrapping to download the Salt Bundle and allow Salt code execution. To allow for this download, a custom policy is written when SELinux is enabled and the system is managed via a tunnel. The policy is only written and loaded once. Fixes bsc#1217594 (cherry picked from commit bc2d962) * preflight.sh: Fix shell syntax (uyuni-project#8165) In Bash, the string to the right of the =~ operator is interpreted as a POSIX extended regular expression. A quoted expression is matched literally, therefore we can't quote the string on the right side. Other than that, there were a few slips (redirection, missing "fi", missing "+" in regex) (cherry picked from commit 3eaae2b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
In Bash, the string to the right of the =~ operator is interpreted as a POSIX extended regular expression. A quoted expression is matched literally, therefore we can't quote the string on the right side.
GUI diff
No difference.
Documentation
Test coverage
Links
Issue(s): https://github.com/SUSE/spacewalk/issues/23369
Old PR causing the issues: #8034
Ports(s): # add downstream PR(s), if any
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:
Before you merge
Check How to branch and merge properly!