Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing reposync for rocky 9 on uyuni #8166

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

Bischoff
Copy link
Contributor

@Bischoff Bischoff commented Jan 15, 2024

What does this PR change?

  • add missing scenario for rocky9 under uyuni
  • make package lists in constants match with the ones in feature
  • fix waiting for RES 8

Links

Ports:

  • 4.3: SUSE/spacewalk#23422

Changelogs

  • No changelog needed

@Bischoff Bischoff requested a review from a team as a code owner January 15, 2024 13:08
Copy link
Contributor

@ktsamis ktsamis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice catches

Copy link
Contributor

👋 Hello! Thanks for contributing to our project.
Acceptance tests will take some time (aprox. 1h), please be patient ☕
You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/8166/checks
Once tests finish, if they fail, you can check 👀 the cucumber report. See the link at the output of the action.
You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/8166/checks.

If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code.

Reference tests:

KNOWN ISSUES

Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience.

For more tips on troubleshooting, see the troubleshooting guide.

Happy hacking!
⚠️ You should not merge if acceptance tests fail to pass. ⚠️

@@ -590,7 +590,7 @@ Feature: Synchronize products in the products page of the Setup Wizard
@rocky8_minion
Scenario: Add Rocky Linux 8
When I use spacewalk-common-channel to add channel "rockylinux8 rockylinux8-appstream rockylinux8-extras rockylinux8-uyuni-client-devel" with arch "x86_64"
And I wait until all synchronized channels for "res8" have finished
And I wait until all synchronized channels for "rockylinux-8" have finished
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just fine for now with this change, so we fix it now.
But... it's weird that in Uyuni we cover Rocky 8 with Pure Rocky 8 channels, while in SUMA we cover Rocky 8 with Liberty 8 channels.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was assuming it was intentional to do so ??

@raulillo82 raulillo82 merged commit 363ab1c into uyuni-project:master Jan 15, 2024
17 checks passed
@Bischoff Bischoff deleted the uyuni-add-rocky-9 branch January 16, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants