Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not require SUSE-Manager-Server-release for susemanager-branding-oss #8178

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

juliogonzalez
Copy link
Member

@juliogonzalez juliogonzalez commented Jan 17, 2024

What does this PR change?

Do not require SUSE-Manager-Server-release for susemanager-branding-oss

We only required it because of the EULA, as that package has it, but unfortunately we won't be able to depend on it, as SUSE-Manager-Server-release is a package for the host, and not for the containers.

SUSE-Manager-Server-release is generated in the SLE15SP5 based codestream, while other packages including susemanager-branding-oss are based in the SLE15SP6 codestream, and doesn't have visibility of this

We'll need to find a way of getting the EULA. Could be buildrequiring a skelcd package that has it.

Does not build for Uyuni neither on top of openSUSE or on top of SLE: https://build.opensuse.org/package/show/home:juliogonzalez:branches:systemsmanagement:Uyuni:Master/susemanager-branding-oss
Builds on top of SLE: https://build.suse.de/package/show/home:juliogonzalezgil:branches:Devel:Galaxy:Manager:Head/susemanager-branding-oss

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed: Internal change

  • DONE

Test coverage

  • No tests: Problems detected by OBS.

  • DONE

Links

Issue(s): https://github.com/SUSE/spacewalk/issues/22011

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

Copy link
Contributor

@deneb-alpha deneb-alpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thanks

@juliogonzalez juliogonzalez merged commit ab8d82b into uyuni-project:master Jan 17, 2024
15 checks passed
@juliogonzalez juliogonzalez deleted the oss-more-fixes branch January 17, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants