Table filters description fix #8791

bisht-richa · 2024-05-22T09:47:15Z

What does this PR change?

Fixed table filters for description, first character and toggle in the updated theme
add description

GUI diff

No difference.

Before:

After:

DONE

Documentation

No documentation needed
DONE

Test coverage

No tests needed
DONE

Links

Fixes: #8725
Port(s): # add downstream PR(s), if any

DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

Re-run test "changelog_test"
Re-run test "backend_unittests_pgsql"
Re-run test "java_pgsql_tests"
Re-run test "schema_migration_test_pgsql"
Re-run test "susemanager_unittests"
Re-run test "javascript_lint"
Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

github-actions · 2024-05-22T09:47:28Z

👋 Hello! Thanks for contributing to our project.
Acceptance tests will take some time (aprox. 1h), please be patient ☕
You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/8791/checks
Once tests finish, if they fail, you can check 👀 the cucumber report. See the link at the output of the action.
You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/8791/checks.

If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code.

Reference tests:

KNOWN ISSUES

Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience.

For more tips on troubleshooting, see the troubleshooting guide.

Happy hacking!
⚠️ You should not merge if acceptance tests fail to pass. ⚠️

github-actions · 2024-05-22T09:47:43Z

Suggested tests to cover this Pull Request

minssh_bootstrap_api
srv_channels_add
min_rhlike_monitoring
min_deblike_remote_command
srv_power_management
srv_power_management_api
srv_logfile
min_action_chain
min_project_lotus
minssh_move_from_and_to_proxy
min_deblike_openscap_audit
proxy_retail_pxeboot_and_mass_import
srv_check_sync_source_packages
min_salt_minions_page
allcli_overview_systems_details
min_bootstrap_reactivation
allcli_config_channel
minkvm_guests
min_salt_formulas
min_ansible_control_node
srv_patches_page
min_salt_formulas_advanced
srv_payg_ssh_connection
srv_handle_software_channels_with_ISS_v2
srv_docker
proxy_register_as_minion_with_script
srv_datepicker
min_salt_openscap_audit
minssh_ansible_control_node
min_salt_install_package
srv_user_configuration_salt_states
allcli_system_group
srv_group_union_intersection
min_check_patches_install
srv_change_password
srv_users
allcli_action_chain
srv_power_management_redfish
srv_user_preferences
min_recurring_action
min_monitoring
srv_dist_channel_mapping
min_salt_pkgset_beacon
minssh_salt_install_package
buildhost_osimage_build_image
srv_check_channels_page
srv_disable_local_repos_off
proxy_branch_network
min_activationkey
min_deblike_ssh
srv_clone_channel_npn
min_salt_user_states
srv_manage_activationkey
allcli_reboot
srv_notifications
min_config_state_channel_subscriptions
min_custom_pkg_download_endpoint
sle_minion
sle_ssh_minion
srv_reportdb
min_rhlike_ssh
srv_docker_advanced_content_management
srv_change_task_schedule
min_virthost
srv_mainpage
min_rhlike_remote_command
min_salt_minion_details
srv_salt_download_endpoint
srv_check_reposync
srv_wait_for_reposync
min_salt_software_states
min_salt_migration
min_cve_audit
srv_activationkey_api
min_config_state_channel
min_deblike_monitoring
srv_content_lifecycle
srv_cobbler_sync
srv_manage_channels_page
srv_create_activationkey
min_rhlike_salt_install_package_and_patch
min_move_from_and_to_proxy
srv_organization_credentials
srv_first_settings
srv_cobbler_distro
srv_push_package
min_bootstrap_ssh_key
srv_add_rocky8_repositories
min_bootstrap_api
srv_channel_api
min_salt_mgrcompat_state
min_timezone
srv_delete_channel_from_ui
srv_salt
min_rhlike_openscap_audit
min_deblike_salt
buildhost_docker_build_image
srv_docker_cve_audit
allcli_software_channels_dependencies
srv_cobbler_buildiso
srv_rename_hostname
min_empty_system_profiles
min_deblike_salt_install_package
srv_custom_system_info
min_retracted_patches
min_bootstrap_script
proxy_as_pod_basic_tests
allcli_update_activationkeys
min_deblike_salt_install_with_staging
min_ssh_tunnel
srv_handle_config_channels_with_ISS_v2
srv_delete_channel_with_tool
min_docker_api
srv_distro_cobbler
srv_cobbler_profile
srv_restart
min_salt_install_with_staging
srv_sync_channels
srv_scc_user_credentials
srv_task_status_engine
srv_maintenance_windows
min_salt_lock_packages
min_bootstrap_negative
min_change_software_channel
srv_osimage
srv_monitoring
buildhost_bootstrap
srv_enable_sync_products
min_cve_id_new_syntax
allcli_software_channels
min_rhlike_salt
srv_create_repository
minssh_action_chain
srv_menu
srv_advanced_search
allcli_sanity
proxy_cobbler_pxeboot
srv_sync_products
srv_virtual_host_manager
buildhost_docker_auth_registry

Etheryte · 2024-05-22T12:02:47Z

If the pages where this is fixed now look all good they also need to be added to the migrated pages list. Please see the original ticket description.

Etheryte · 2024-05-23T09:03:23Z

java/code/src/com/suse/manager/webui/utils/ViewHelper.java

+        "/rhn/manager/systems/list/all",
+        "/rhn/manager/contentmanagement/projects",
+        "/rhn/kickstart/cobbler/DefaultSnippetList.do",
+        "/rhn/systems/details/packages/PackageList.do?sid=1000010006&",


This won't work, we need to check whether we need to handle params in a specific way or if we can just use the base, but the param value definitely doesn't belong here.

Etheryte · 2024-05-23T09:03:49Z

web/html/src/branding/css/susemanager/components/panels.uyuni.scss

@@ -1,7 +1,6 @@
 .panel {
  border-radius: $border-radius;
  box-shadow: 0 1px 1px rgba(0, 0, 0, 0.05);
-  overflow: hidden;


Are we sure this is safe to remove? This is a globally used component.

Etheryte · 2024-05-23T09:05:21Z

web/html/src/branding/css/susemanager/components/buttons.scss

@@ -74,3 +74,7 @@ button.is-plain {
    }
  }
 }
+
+.input-group-btn .btn {
+  padding: 10px 9px;


This does not look like it can be right. The paddings used in the Suma theme and Uyuni theme are different, I doubt this value works for both?

I will have a look

Etheryte

Looks good, thanks a lot for taking the time to fix this. 👍

parlt91

LGTM

bisht-richa requested review from a team as code owners May 22, 2024 09:47

bisht-richa requested review from parlt91 and removed request for a team May 22, 2024 09:47

github-actions bot added java java_lint_checkstyle java_pgsql_tests API ui javascript_lint old-ui labels May 22, 2024

github-actions bot added the needs-translation label May 22, 2024

bisht-richa force-pushed the table-filters-description-fix branch from c039993 to 10ea4b9 Compare May 22, 2024 13:11

Etheryte reviewed May 23, 2024

View reviewed changes

bisht-richa added 7 commits May 24, 2024 13:14

Fixed filters - description, first character dropdown and toggle button

3e97ae1

Fixed disabled state for dropdown list

b3cf8ea

Clean up

f6a1ee8

Added change log

11af214

Added pages to the migrated pages list

2248698

Fixed lint

2945f60

Fixed review comments

ebc0484

bisht-richa force-pushed the table-filters-description-fix branch from efc47e6 to ebc0484 Compare May 24, 2024 11:17

Added comma in page list

5e15035

Etheryte approved these changes May 24, 2024

View reviewed changes

parlt91 approved these changes Jun 6, 2024

View reviewed changes

admd merged commit 96b2cb0 into master Jul 23, 2024
29 checks passed

admd deleted the table-filters-description-fix branch July 23, 2024 09:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Table filters description fix #8791

Table filters description fix #8791

bisht-richa commented May 22, 2024 •

edited by Etheryte

Loading

github-actions bot commented May 22, 2024

github-actions bot commented May 22, 2024 •

edited

Loading

Etheryte commented May 22, 2024

Etheryte May 23, 2024

Etheryte May 23, 2024

Etheryte May 23, 2024

bisht-richa May 23, 2024

Etheryte left a comment

parlt91 left a comment

Table filters description fix #8791

Table filters description fix #8791

Conversation

bisht-richa commented May 22, 2024 • edited by Etheryte Loading

What does this PR change?

GUI diff

Documentation

Test coverage

Links

Changelogs

Re-run a test

Before you merge

github-actions bot commented May 22, 2024

github-actions bot commented May 22, 2024 • edited Loading

Etheryte commented May 22, 2024

Etheryte May 23, 2024

Choose a reason for hiding this comment

Etheryte May 23, 2024

Choose a reason for hiding this comment

Etheryte May 23, 2024

Choose a reason for hiding this comment

bisht-richa May 23, 2024

Choose a reason for hiding this comment

Etheryte left a comment

Choose a reason for hiding this comment

parlt91 left a comment

Choose a reason for hiding this comment

bisht-richa commented May 22, 2024 •

edited by Etheryte

Loading

github-actions bot commented May 22, 2024 •

edited

Loading