Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table filters description fix #8791

Merged
merged 8 commits into from
Jul 23, 2024
Merged

Table filters description fix #8791

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3e97ae1
Fixed filters - description, first character dropdown and toggle button
bisht-richa May 20, 2024
b3cf8ea
Fixed disabled state for dropdown list
bisht-richa May 22, 2024
f6a1ee8
Clean up
bisht-richa May 22, 2024
11af214
Added change log
bisht-richa May 22, 2024
2248698
Added pages to the migrated pages list
bisht-richa May 22, 2024
2945f60
Fixed lint
bisht-richa May 22, 2024
ebc0484
Fixed review comments
bisht-richa May 23, 2024
5e15035
Added comma in page list
bisht-richa May 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion java/code/src/com/redhat/rhn/frontend/taglibs/list/ListTagUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -645,7 +645,7 @@ else if (fields.size() == 1) {
StringBuilder sb = new StringBuilder();

// create a new row
sb.append("<div class=\"input-group input-group-sm\">");
sb.append("<div class=\"input-group\">");

String placeHolder = StringUtils.defaultString(ls.getMessage("message.filterby", fields.get(0)));
sb.append(String.format("<input autofocus=\"autofocus\" type=\"text\" " +
Expand Down
8 changes: 7 additions & 1 deletion java/code/src/com/suse/manager/webui/utils/ViewHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,13 @@ public enum ViewHelper {
"/rhn/account/EditAddress.do",
"/rhn/multiorg/OrgConfigDetails.do",
"/rhn/manager/notification-messages",
"rhn/channels/software/Search.do"
"rhn/channels/software/Search.do",
"/rhn/activationkeys/List.do",
"/rhn/manager/systems/list/all",
"/rhn/manager/contentmanagement/projects",
"/rhn/kickstart/cobbler/DefaultSnippetList.do",
"/rhn/systems/details/packages/PackageList.do",
"/rhn/software/channels/All.do"
);

ViewHelper() { }
Expand Down
1 change: 1 addition & 0 deletions java/spacewalk-web.changes.bisht-richa.table-filters-description-fix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Fixed table filters for description, first character dropdown and toggle button.
8 changes: 8 additions & 0 deletions web/html/src/branding/css/base/theme.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -546,6 +546,12 @@ nav.navbar-pf {
max-height: 250px;
overflow-y: auto;
text-align: right;
font-size: 14px;
left: 0;
background: $white;
border: 1px solid #ccc;
border-radius: 4px;
box-shadow: 0 6px 12px rgba(0, 0, 0, 0.175);
li {
display: block;
padding: 0 1px;
Expand All @@ -559,6 +565,8 @@ nav.navbar-pf {
li.disabled {
a {
color: #aaa;
text-decoration: none;
cursor: not-allowed;
}
}
li:nth-child(11) {
Expand Down
4 changes: 4 additions & 0 deletions web/html/src/branding/css/susemanager/components/inputs.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,3 +90,7 @@ select[size] {
margin: 0 !important;
}
}

.input-group {
align-items: center;
}
6 changes: 6 additions & 0 deletions web/html/src/core/spa/view-helper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,12 @@ const BOOTSTRAP_READY_PAGES: string[] = [
"/rhn/multiorg/OrgConfigDetails.do",
"/rhn/manager/notification-messages",
"rhn/channels/software/Search.do",
"/rhn/activationkeys/List.do",
"/rhn/manager/systems/list/all",
"/rhn/manager/contentmanagement/projects",
"/rhn/kickstart/cobbler/DefaultSnippetList.do",
"/rhn/systems/details/packages/PackageList.do",
"/rhn/software/channels/All.do",
];

export const onEndNavigate = () => {
Expand Down
1 change: 1 addition & 0 deletions web/spacewalk-web.changes.bisht-richa.table-filters-description-fix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Fixed table filters for description, first character dropdown and toggle button.
Loading