-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid executing commands from path #8952
base: master
Are you sure you want to change the base?
Avoid executing commands from path #8952
Conversation
Suggested tests to cover this Pull Request
|
👋 Hello! Thanks for contributing to our project. If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code. Reference tests: KNOWN ISSUES Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience. For more tips on troubleshooting, see the troubleshooting guide. Happy hacking! |
1fd9183
to
cd3ca3c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
found some missing commands
java/code/src/com/redhat/rhn/taskomatic/task/repomd/RpmRepositoryWriter.java
Outdated
Show resolved
Hide resolved
susemanager-utils/susemanager-sls/salt/cocoattest/requestdata.sls
Outdated
Show resolved
Hide resolved
susemanager-utils/susemanager-sls/salt/cocoattest/requestdata.sls
Outdated
Show resolved
Hide resolved
susemanager-utils/susemanager-sls/salt/packages/redhatproductinfo.sls
Outdated
Show resolved
Hide resolved
susemanager-utils/susemanager-sls/salt/srvmonitoring/disable.sls
Outdated
Show resolved
Hide resolved
susemanager-utils/susemanager-sls/salt/srvmonitoring/enable.sls
Outdated
Show resolved
Hide resolved
susemanager-utils/susemanager-sls/salt/util/mgr_switch_to_venv_minion.sls
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
8d6e51a
to
55f71b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
What does this PR change?
This PR uses absolute paths when invoking commands to avoid using the
PATH
environment variable and thus avoid being subjected to possible environment injection attacks.GUI diff
No difference.
Documentation
No documentation needed: only internal and user invisible changes
DONE
Test coverage
No tests: already covered
DONE
Links
Issue(s): https://github.com/SUSE/spacewalk/issues/24387
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test
(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:
Before you merge
Check How to branch and merge properly!