Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bootstrap updates and fixes #9089

Merged
merged 16 commits into from
Jul 24, 2024
Merged

Bootstrap updates and fixes #9089

merged 16 commits into from
Jul 24, 2024

Conversation

cbbayburt
Copy link
Contributor

This PR is a collection of @bisht-richa and @Etheryte's reviewed PRs. Below is a list of all the PRs included:

All PRs have been reviewed individually

Links

Epic: https://github.com/SUSE/spacewalk/issues/18940

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

@bisht-richa
Review fix ssm subpages (#8899)
530546a 
* Fixed from read only state
* Fixed SSM subpages layout
* Added change log
* Fixed active and focus state css
@bisht-richa
Btn info inconsistent (#8907)
99d5c0a 
* Fixed info button style in new theme
* Added change log
* Fixed spcae error in ViewHelper.java
@bisht-richa
Fix broken layout of system formulas configuration page (#8919)
c6473f7
@bisht-richa
Fixed table footer top border (#8925)
ee37324
@bisht-richa @cbbayburt
Fixed broken layout of system highstate page (#8933)
90ea8a8
@bisht-richa
Added label css (#8936)
6bc7cc0
@bisht-richa
Fixed missing margins in CVE audit (#8947)
2c8fa79
@bisht-richa
Fixed advanced package search page layout (#8956)
6719ea0
@bisht-richa
Fixed OpenSCAP search page layout (#8960)
832b987
@bisht-richa
Fixed double padding in recurring actions (#8963)
a1dffa5
@bisht-richa
Fixed missing margin between inline radio buttons (#8976)
b001501
@bisht-richa
Fixed broken layout in monitoring page (#8977)
aa301bc
@bisht-richa
Fixed hidden section issue in new theme (#8987)
89f9345
@bisht-richa
Fixed space between radio button and label (#8996)
b757f16 
* Fixed space between radio button and label
* Removed extra space from file name
* Fixed Inventory Path dropdown box alignment
* Clean code
@bisht-richa
Fixed build image page layout in new theme (#9004)
ebde181
@cbbayburt cbbayburt requested review from a team as code owners July 23, 2024 18:11
@cbbayburt cbbayburt requested review from parlt91 and admd and removed request for a team July 23, 2024 18:11
@github-actions GitHub Actions
Copy link
Contributor

Suggested tests to cover this Pull Request
  • minssh_bootstrap_api
  • srv_channels_add
  • min_rhlike_monitoring
  • min_deblike_remote_command
  • srv_power_management
  • srv_power_management_api
  • srv_logfile
  • min_action_chain
  • min_project_lotus
  • minssh_move_from_and_to_proxy
  • min_deblike_openscap_audit
  • proxy_retail_pxeboot_and_mass_import
  • srv_check_sync_source_packages
  • min_salt_minions_page
  • allcli_sanity
  • allcli_overview_systems_details
  • proxy_cobbler_pxeboot
  • min_bootstrap_reactivation
  • allcli_config_channel
  • minkvm_guests
  • min_salt_formulas
  • srv_sync_products
  • min_ansible_control_node
  • srv_patches_page
  • min_salt_formulas_advanced
  • srv_payg_ssh_connection
  • srv_handle_software_channels_with_ISS_v2
  • srv_docker
  • proxy_register_as_minion_with_script
  • srv_datepicker
  • min_salt_openscap_audit
  • minssh_ansible_control_node
  • min_salt_install_package
  • srv_user_configuration_salt_states
  • allcli_system_group
  • srv_group_union_intersection
  • min_check_patches_install
  • srv_change_password
  • srv_users
  • allcli_action_chain
  • srv_power_management_redfish
  • srv_user_preferences
  • min_recurring_action
  • min_monitoring
  • srv_dist_channel_mapping
  • min_salt_pkgset_beacon
  • minssh_salt_install_package
  • buildhost_osimage_build_image
  • srv_check_channels_page
  • srv_disable_local_repos_off
  • proxy_branch_network
  • min_activationkey
  • min_deblike_ssh
  • srv_clone_channel_npn
  • min_salt_user_states
  • srv_virtual_host_manager
  • srv_manage_activationkey
  • allcli_reboot
  • srv_notifications
  • min_config_state_channel_subscriptions
  • min_custom_pkg_download_endpoint
  • sle_minion
  • sle_ssh_minion
  • srv_reportdb
  • min_rhlike_ssh
  • srv_docker_advanced_content_management
  • srv_change_task_schedule
  • min_virthost
  • srv_mainpage
  • min_rhlike_remote_command
  • min_salt_minion_details
  • srv_salt_download_endpoint
  • srv_check_reposync
  • srv_wait_for_reposync
  • min_salt_software_states
  • min_salt_migration
  • min_cve_audit
  • srv_activationkey_api
  • min_config_state_channel
  • min_deblike_monitoring
  • srv_content_lifecycle
  • srv_cobbler_sync
  • srv_manage_channels_page
  • srv_create_activationkey
  • min_rhlike_salt_install_package_and_patch
  • min_move_from_and_to_proxy
  • srv_organization_credentials
  • srv_first_settings
  • srv_cobbler_distro
  • srv_push_package
  • buildhost_docker_auth_registry
  • min_bootstrap_ssh_key
  • srv_add_rocky8_repositories
  • min_bootstrap_api
  • srv_channel_api
  • min_salt_mgrcompat_state
  • min_timezone
  • srv_delete_channel_from_ui
  • srv_salt
  • min_rhlike_openscap_audit
  • min_deblike_salt
  • buildhost_docker_build_image
  • srv_docker_cve_audit
  • allcli_software_channels_dependencies
  • srv_cobbler_buildiso
  • srv_rename_hostname
  • min_empty_system_profiles
  • min_deblike_salt_install_package
  • srv_custom_system_info
  • min_retracted_patches
  • min_bootstrap_script
  • proxy_as_pod_basic_tests
  • allcli_update_activationkeys
  • min_deblike_salt_install_with_staging
  • min_ssh_tunnel
  • srv_handle_config_channels_with_ISS_v2
  • srv_delete_channel_with_tool
  • min_docker_api
  • srv_distro_cobbler
  • srv_cobbler_profile
  • srv_restart
  • min_salt_install_with_staging
  • srv_sync_channels
  • srv_scc_user_credentials
  • srv_task_status_engine
  • srv_maintenance_windows
  • min_salt_lock_packages
  • min_bootstrap_negative
  • min_change_software_channel
  • srv_osimage
  • srv_monitoring
  • buildhost_bootstrap
  • srv_enable_sync_products
  • min_cve_id_new_syntax
  • allcli_software_channels
  • min_rhlike_salt
  • srv_create_repository
  • minssh_action_chain
  • srv_menu
  • srv_advanced_search

@github-actions GitHub Actions
Copy link
Contributor

👋 Hello! Thanks for contributing to our project.
Acceptance tests will take some time (aprox. 1h), please be patient ☕
You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/9089/checks
Once tests finish, if they fail, you can check 👀 the cucumber report. See the link at the output of the action.
You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/9089/checks.

If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code.

Reference tests:

KNOWN ISSUES

Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience.

For more tips on troubleshooting, see the troubleshooting guide.

Happy hacking!
⚠️ You should not merge if acceptance tests fail to pass. ⚠️

@admd
Copy link
Contributor

admd commented Jul 24, 2024

Some tests are failing @cbbayburt . Can you please take a look.

@admd admd closed this Jul 24, 2024
@admd admd reopened this Jul 24, 2024
@admd admd merged commit 7808370 into master Jul 24, 2024
27 checks passed
@admd admd deleted the bootstrap-updates branch July 24, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@admd admd admd approved these changes

@parlt91 parlt91 Awaiting requested review from parlt91 parlt91 is a code owner automatically assigned from uyuni-project/java

Assignees
No one assigned
Labels
java_lint_checkstyle java_pgsql_tests java javascript_lint needs-translation ui webapp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cbbayburt @admd @bisht-richa @Etheryte