Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo on directories to cleanup when deleting a system (bsc#1228101) #9099

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

meaksh
Copy link
Member

@meaksh meaksh commented Jul 24, 2024

What does this PR change?

This PR fixes a typo on the paths to some minion files to cleanup when deleting a system in Uyuni. This was noticed as the /etc/venv-salt-minion/pki/minion/minion_master.pub and some other files were not cleaned up properly during system deletion as it was expected.

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed: only internal and user invisible changes

  • DONE

Test coverage

  • No tests: no tests for this

  • DONE

Links

Issue(s): https://github.com/SUSE/spacewalk/issues/24906
Port(s): https://github.com/SUSE/spacewalk/pull/24907

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

Copy link
Contributor

@avshiliaev avshiliaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@meaksh meaksh added the merge-candidate Meaning it needs to be considered for merging when the master branch is frozen label Jul 24, 2024
@deneb-alpha deneb-alpha merged commit 5c718db into uyuni-project:master Jul 24, 2024
21 checks passed
@meaksh meaksh deleted the master-bsc1228101 branch July 25, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-candidate Meaning it needs to be considered for merging when the master branch is frozen
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants