Fix error in 'kickstart_delete' when using wildcards (bsc#1227578) #9103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agraul
reviewed
Jul 25, 2024
| @@ -374,9 +374,9 @@ def test_kickstart_delete_invalid_profile(self, shell): | |||
| assert_args_expect(shell.do_kickstart_list.call_args_list, | |||
| [(('', True), {})]) | |||
|
|
|||
| def test_kickstart_delete_some_invalid_profile(self, shell): | |||
There was a problem hiding this comment.
No, this one tests for the case I removed in the code. Basically, if some of the args are not found, it used to throw an error, which didn't work with wildcards. Now it works with only the args it could match. The removed part doesn't exist in any other methods that deal with the globs in the same way, so I removed it from this as well.
There was a problem hiding this comment.
How does the user know that some of the passed profiles were not found after your change?
There was a problem hiding this comment.
User needs to confirm y/n for every matched label one by one.
Plus, deleted labels are displayed in the output in the end.
meaksh
approved these changes
Sep 23, 2024
cbbayburt
added
the
merge-candidate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
kickstart_delete, the code first resolves wildcard arguments and returns matching labels. Then it tries to make sure if every arg actually matched a result. But since the original wildcard args don't literally match the resulting labels, the second check throws an error. This PR removes the second check (only exists in this method) to match the method with the rest of the system.See bug: https://bugzilla.suse.com/show_bug.cgi?id=1227578
Documentation
Test coverage
Links
Fixes https://github.com/SUSE/spacewalk/issues/24761
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:
Before you merge
Check How to branch and merge properly!