spacecmd: speedup softwarechannel_removepackages #9128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vzhestkov
approved these changes
Aug 5, 2024
agraul
changed the title
agraul
added
the
merge-candidate
Instead of converting the list of dictionaries to strings and later find each package db id from the local cache (which needs to be built first), we can build ourselves a dictionary with the same package name string as the key and the id as the value. This approach bypasses building the cache. A request to list all packages for the requested channel takes place either way and did not use the cache. Fixes bsc#1227606
agraul
force-pushed
the
spacecmd-speedup-softwarechannel_removepackages
branch
from
484ef89
to
2148e0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Speedup softwarechannel_removepackages
Instead of converting the list of dictionaries to strings and later find each package db id from the local cache (which needs to be built first), we can build ourselves a dictionary with the same package name string as the key and the id as the value. This approach bypasses building the cache. A request to list all packages for the requested channel takes place either way and did not use the cache.
GUI diff
No difference.
Documentation
No documentation needed: only internal and user invisible changes
DONE
Test coverage
Unit tests were added
DONE
Links
Issue(s): https://github.com/SUSE/spacewalk/issues/24775
Port(s): https://github.com/SUSE/spacewalk/pull/24973, https://github.com/SUSE/spacewalk/pull/25203
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:
Before you merge
Check How to branch and merge properly!