-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QE: Multiple test framework refactors #9181
Conversation
👋 Hello! Thanks for contributing to our project. If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code. Reference tests: KNOWN ISSUES Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience. For more tips on troubleshooting, see the troubleshooting guide. Happy hacking! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for all this work
|
GitHub PR acceptance tests: Run ./testsuite/podman_runner/05_install_gems_in_controller.sh
+ sudo -i podman exec controller bash -c 'export GEM_PATH="/usr/lib64/ruby/gems/3.3.0"'
+ sudo -i podman exec controller bash -c 'cd /testsuite && bundle.ruby3.3 install --gemfile Gemfile --verbose'
bash: bundle.ruby3.3: command not found For this to work, we need to update the controller container. However, this is not possible in this PR and would also affect the all other PRs. So for now, we cannot rely on the PR tests here.
|
6c8a54b
to
c7886f8
Compare
Ok, so with the changes as of now, we have one error: I will force push again so that the controller container will get updated only under certain conditions and not for every push to this PR like it is now. |
Rebase done. |
Another rebase to include mcs test suite fixes. |
f8a8955
to
797fbd9
Compare
Fixes SUSE/spacewalk#17431 Signed-off-by: Dominik Gedon <dominik.gedon@suse.com>
…ary_parallelizable.yml in CI (#5743) * Using a new user per feature * Removing refactors made to enable parallel tests, moved to this branch qe-refactor-enabling-parallel-tests * Updating the Copyright year
Signed-off-by: Dominik Gedon <dominik.gedon@suse.com>
Signed-off-by: Dominik Gedon <dominik.gedon@suse.com>
… libraries (#9160) * Refactor the communication with external machines using Ruby built-in libraries * Fix small issues in RemoteNode * Remove Twopence from GH Tests controller image * Remaining issues moving to RemoteNode * Update rubocop rules * Fix issues in RemoteNode
Signed-off-by: Dominik Gedon <dominik.gedon@suse.com>
`net-ssh` does not support Ruby > 3.1, yet. Signed-off-by: Dominik Gedon <dominik.gedon@suse.com>
This reverts commit 6a4719c.
This reverts commit 2086239.
…ommand (#9224) * Handling a reboot of a remote node through net-ssh * Fix scp method
* Force API protocol through a new environment variable * Fix how we handle exit code from a ssh call * Remove not used steps * Refactor some missing Twopence method calls * Prevent a nil exception
Signed-off-by: Dominik Gedon <dominik.gedon@suse.com>
48460cc
to
a9d0755
Compare
Please don't squash commits. This is a special branch that combine multiple refactors, so we prefer to keep a commit per PR merged into this branch, to facilitate navigating over the reasons for each change.
Prerequisites before merging this
What does this PR change?
TODOs
GUI diff
No difference.
Documentation
Test coverage
Links
Issue(s): #
Ports(s): #
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test
(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:
Before you merge
Check How to branch and merge properly!