Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spacecmd type issue during bootstrap #9185

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

m-czernek
Copy link
Contributor

@m-czernek m-czernek commented Aug 20, 2024

What does this PR change?

When executing system bootstrap with specified port number, e.g. system_bootstrap -H suma-new-minion -p 22 -u root -P linux -a 1-sles15-sp5-ssh, the port number is a string. However, SystemHandler expects this to be an int.

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed: only internal and user invisible changes

  • DONE

Links

Issue(s): https://github.com/SUSE/spacewalk/issues/25093
Port(s):

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

@m-czernek m-czernek requested a review from a team as a code owner August 20, 2024 14:56
@m-czernek m-czernek requested review from agraul and removed request for a team August 20, 2024 14:56
@m-czernek m-czernek requested a review from agraul August 22, 2024 13:39
@m-czernek m-czernek added the merge-candidate Meaning it needs to be considered for merging when the master branch is frozen label Sep 2, 2024
@deneb-alpha deneb-alpha merged commit cf15ddb into uyuni-project:master Sep 9, 2024
21 checks passed
@m-czernek m-czernek deleted the spacecmd-bootstrap-fix branch September 10, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-candidate Meaning it needs to be considered for merging when the master branch is frozen needs-translation python3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants