Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix spacecmd type issue during bootstrap #9185

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Fix spacecmd type issue during bootstrap #9185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b4ace38
Fix spacecmd type issue during bootstrap
m-czernek Aug 20, 2024
b31e453
Fail early if port is not numeric
m-czernek Aug 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions spacecmd/spacecmd.changes.mczernek.spacecmd-bootstrap-fix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Spacecmd bootstrap now works with specified port (bsc#1229437)
6 changes: 6 additions & 0 deletions spacecmd/src/spacecmd/system.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4563,6 +4563,12 @@ def do_system_bootstrap(self, args):
if answer in ['y', 'Y']:
options.saltssh = True

if isinstance(options.port, str):
if not options.port.isnumeric():
logging.error(_N("Provided port must be numeric"))
return 1
options.port = int(options.port)

m-czernek marked this conversation as resolved.
Show resolved Hide resolved
if not options.hostname:
logging.error(_N("Hostname must be provided"))
return 1
Expand Down
Loading