Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

7427 cleanup truncata errata #9215

Merged
merged 9 commits into from
Sep 13, 2024
Merged

7427 cleanup truncata errata #9215

merged 9 commits into from
Sep 13, 2024

Conversation

Serp1co
Copy link
Contributor

@Serp1co Serp1co commented Aug 27, 2024 •
edited by mcalmer
Loading

What does this PR change?

ErrataManager.truncateErrata now tries to clean orphan erratas at the end (erratas with no channel)

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed: only internal and user invisible changes

  • DONE

Test coverage

  • No tests: already covered

  • DONE

Links

Issue(s): https://github.com/SUSE/spacewalk/issues/7427
Port(s): # add downstream PR(s), if any

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

@Serp1co Serp1co requested review from mcalmer and mackdk August 27, 2024 12:11
@Serp1co Serp1co requested a review from a team as a code owner August 27, 2024 12:11
@github-actions github-actions bot added the java label Aug 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

👋 Hello! Thanks for contributing to our project.
Acceptance tests will take some time (aprox. 1h), please be patient ☕
You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/9215/checks
Once tests finish, if they fail, you can check 👀 the cucumber report. See the link at the output of the action.
You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/9215/checks.

If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code.

Reference tests:

KNOWN ISSUES

Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience.

For more tips on troubleshooting, see the troubleshooting guide.

Happy hacking!
⚠️ You should not merge if acceptance tests fail to pass. ⚠️

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 27, 2024 •
edited
Loading

Suggested tests to cover this Pull Request
  • srv_delete_channel_with_tool
  • srv_patches_page
  • srv_delete_channel_from_ui
  • srv_handle_software_channels_with_ISS_v2
  • srv_clone_channel_npn
  • srv_change_password
  • srv_check_sync_source_packages
  • srv_check_reposync
  • min_bootstrap_api
  • min_salt_pkgset_beacon
  • srv_cobbler_distro
  • min_recurring_action
  • allcli_software_channels
  • srv_cobbler_profile
  • min_bootstrap_negative
  • buildhost_bootstrap
  • minssh_salt_install_package
  • min_deblike_remote_command
  • min_deblike_ssh
  • min_project_lotus
  • min_config_state_channel
  • min_deblike_salt
  • srv_disable_local_repos_off
  • min_change_software_channel
  • buildhost_docker_auth_registry
  • min_check_patches_install
  • srv_cobbler_sync
  • srv_users
  • srv_handle_config_channels_with_ISS_v2
  • min_retracted_patches
  • min_deblike_monitoring
  • srv_channels_add
  • srv_organization_credentials
  • srv_salt_download_endpoint
  • min_bootstrap_ssh_key
  • min_move_from_and_to_proxy
  • srv_reportdb
  • min_ssh_tunnel
  • min_deblike_salt_install_with_staging
  • srv_channel_api
  • min_salt_mgrcompat_state
  • srv_dist_channel_mapping
  • min_rhlike_monitoring
  • srv_user_configuration_salt_states
  • srv_push_package
  • min_config_state_channel_subscriptions
  • min_empty_system_profiles
  • min_deblike_salt_install_package
  • srv_create_repository
  • srv_payg_ssh_connection
  • min_action_chain
  • min_salt_formulas
  • min_monitoring
  • srv_user_preferences
  • srv_power_management
  • min_salt_openscap_audit
  • min_salt_minions_page
  • srv_power_management_redfish
  • srv_notifications
  • srv_monitoring
  • proxy_as_pod_basic_tests
  • srv_cobbler_buildiso
  • min_salt_migration
  • min_salt_lock_packages
  • srv_first_settings
  • allcli_update_activationkeys
  • buildhost_docker_build_image
  • min_salt_install_package
  • buildhost_osimage_build_image
  • srv_docker_cve_audit
  • srv_advanced_search
  • srv_docker_advanced_content_management
  • srv_task_status_engine
  • srv_power_management_api
  • srv_scc_user_credentials
  • allcli_reboot
  • srv_rename_hostname
  • srv_content_lifecycle
  • minkvm_guests
  • min_deblike_openscap_audit
  • proxy_register_as_minion_with_script
  • min_virthost
  • min_rhlike_remote_command
  • min_salt_software_states
  • min_ansible_control_node
  • allcli_config_channel
  • min_rhlike_openscap_audit
  • srv_salt
  • min_cve_id_new_syntax
  • min_rhlike_salt
  • minssh_move_from_and_to_proxy
  • srv_logfile
  • allcli_software_channels_dependencies
  • min_activationkey
  • proxy_branch_network
  • srv_restart
  • srv_datepicker
  • min_docker_api
  • srv_manage_channels_page
  • minssh_bootstrap_api
  • allcli_system_group
  • min_salt_install_with_staging
  • proxy_retail_pxeboot_and_mass_import
  • min_bootstrap_script
  • min_salt_formulas_advanced
  • srv_enable_sync_products
  • min_cve_audit
  • sle_ssh_minion
  • srv_create_activationkey
  • srv_change_task_schedule
  • min_bootstrap_reactivation
  • allcli_overview_systems_details
  • srv_distro_cobbler
  • min_rhlike_salt_install_package_and_patch
  • srv_osimage
  • minssh_action_chain
  • srv_maintenance_windows
  • min_salt_user_states
  • srv_group_union_intersection
  • min_timezone
  • min_salt_minion_details
  • srv_check_channels_page
  • srv_menu
  • srv_mainpage
  • min_rhlike_ssh
  • sle_minion
  • srv_sync_channels
  • srv_add_rocky8_repositories
  • srv_activationkey_api
  • min_custom_pkg_download_endpoint
  • allcli_action_chain

mcalmer
mcalmer previously approved these changes Aug 28, 2024
View reviewed changes
@Serp1co Serp1co added the merge-candidate Meaning it needs to be considered for merging when the master branch is frozen label Aug 30, 2024
mackdk
mackdk previously approved these changes Sep 9, 2024
View reviewed changes
java/code/src/com/redhat/rhn/manager/errata/ErrataManager.java Outdated
Comment on lines 650 to 652
OwnedErrata oErrata = new OwnedErrata();
oErrata.setId(errata.getId());
oErrata.setAdvisory(errata.getAdvisory());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicking here, but I would move this code into a OwnedErrata construct, so that we can just call new OwnedErrata(errata).

@Serp1co Serp1co dismissed stale reviews from mackdk and mcalmer via f4a0625 September 13, 2024 13:35
@deneb-alpha deneb-alpha merged commit 8d6d3ca into uyuni-project:master Sep 13, 2024
21 checks passed
cbbayburt pushed a commit to cbbayburt/uyuni that referenced this pull request Sep 26, 2024
@mackdk @Serp1co
7427 cleanup truncata errata (uyuni-project#9215) (#25336)
8759523 
* cleanup truncata
* errata cleanup and ownederrata constructor
* refactoring with method for creating ownederrata (cleaner)
* fix for deleting the filteredErrata
* owned errata constructor from errata

(cherry picked from commit 8d6d3ca)

Co-authored-by: Manuel Salvi <manuel.salvi@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mackdk mackdk mackdk approved these changes

@mcalmer mcalmer mcalmer left review comments

Assignees
No one assigned
Labels
API java_lint_checkstyle java_pgsql_tests java merge-candidate Meaning it needs to be considered for merging when the master branch is frozen old-ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Serp1co @mcalmer @mackdk @deneb-alpha