Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sticky header scroll bug #9286

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Conversation

Etheryte
Copy link
Member

What does this PR change?

The legacy script that handles sticky headers doesn't account for the fact that some pages may have multiple sections which are sticky header candidates. In the future we want to move this over to a purely CSS solution since position: sticky is now widely supported, for the time being this PR fixes the infinite layout expansion bug.

GUI diff

No more infinite scroll.

  • DONE

Documentation

  • No documentation needed: bugfix

  • DONE

Test coverage

ℹ️ If a major new functionality is added, it is strongly recommended that tests for the new functionality are added to the Cucumber test suite

  • No tests: UI bug

  • DONE

Links

https://suse.slack.com/archives/C02D130RBA6/p1726915321046259

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

rjmateus
rjmateus previously approved these changes Sep 23, 2024
@Etheryte Etheryte added the merge-candidate Meaning it needs to be considered for merging when the master branch is frozen label Sep 23, 2024
bisht-richa
bisht-richa previously approved these changes Sep 23, 2024
Copy link
Contributor

@bisht-richa bisht-richa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Marina Latini <marina.latini@suse.com>
@Etheryte Etheryte dismissed stale reviews from bisht-richa and rjmateus via 9868d55 September 23, 2024 12:18
Copy link
Contributor

@deneb-alpha deneb-alpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deneb-alpha deneb-alpha merged commit 3c139ae into uyuni-project:master Sep 24, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript_lint merge-candidate Meaning it needs to be considered for merging when the master branch is frozen needs-translation ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants