Enhance mechanism to cleanup old Salt Bundle environment (bsc#1228690) #9336
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
This PR passes
SALT_HIGHSTATE=1
when callingpost_start_cleanup.sh
as part of the highstate. This way, we allowpost_start_cleanup.sh
script to detect when it is triggered byvenv-salt-minion-postinstall.service
or highstate.This way, together with the changes in the
post_start_cleanup.sh
script done here: https://build.opensuse.org/request/show/1206496, we prevent an early cleanup of the environment by the timer when there is still running Salt Bundle upgrade action.This helps to prevent the following exception when triggering a patch upgrade containing Salt Bundle plus lot of other patches:
GUI diff
No difference.
Documentation
No documentation needed: only internal and user invisible changes
DONE
Test coverage
No tests: no acceptance tests yet Salt Bundle upgrade
DONE
Links
Issue(s): https://github.com/SUSE/spacewalk/issues/24978
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test
(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:
Before you merge
Check How to branch and merge properly!