Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix indentation issues and remove a feature to create bootstrap repositories in BV that it's doing a duplicate action, that we do in the template. #9377

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

maximenoel8
Copy link
Contributor

What does this PR change?

Fix some indentation issues in features. And remove useless file.

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed: only internal and user invisible changes

  • DONE

Test coverage

ℹ️ If a major new functionality is added, it is strongly recommended that tests for the new functionality are added to the Cucumber test suite

  • No tests: already covered

  • DONE

Links

Port:
Issue:

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_lint_checkstyle"
  • Re-run test "java_pgsql_tests"
  • Re-run test "ruby_rubocop"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

@maximenoel8 maximenoel8 requested a review from a team as a code owner October 16, 2024 21:14
@maximenoel8 maximenoel8 self-assigned this Oct 16, 2024
Copy link
Contributor

👋 Hello! Thanks for contributing to our project.
Acceptance tests will take some time (aprox. 1h), please be patient ☕
You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/9377/checks
Once tests finish, if they fail, you can check 👀 the cucumber report. See the link at the output of the action.
You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/9377/checks.

If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code.

Reference tests:

KNOWN ISSUES

Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience.

For more tips on troubleshooting, see the troubleshooting guide.

Happy hacking!
⚠️ You should not merge if acceptance tests fail to pass. ⚠️

@maximenoel8 maximenoel8 changed the title Fix indent detect porudct loading issue Fix indentation issues. Oct 16, 2024
Copy link
Contributor

@szachovy szachovy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you elaborate on why this file is removed? I don't see these scenarios running elsewhere. If you have already done it, copy and paste text or reference under this comment.

@maximenoel8
Copy link
Contributor Author

maximenoel8 commented Oct 17, 2024

This file is a left over from previous BV ( sequential ). Currently we are using the template and not this feature.
It's related to this https://github.com/SUSE/spacewalk/issues/22374 but there are no much details in there too.

@srbarrios srbarrios changed the title Fix indentation issues. Fix indentation issues and remove a feature to create bootstrap repositories in BV that it's doing a duplicate action Oct 17, 2024
@srbarrios srbarrios changed the title Fix indentation issues and remove a feature to create bootstrap repositories in BV that it's doing a duplicate action Fix indentation issues and remove a feature to create bootstrap repositories in BV that it's doing a duplicate action, that we do in the template. Oct 17, 2024
@srbarrios
Copy link
Member

FMPOV, indentation issues is the less important part of this PR, so I edited the title to assure that we mention the fact that we had a duplicated action in BV.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants