Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic themes #336

Open
vaadin-miki opened this issue Dec 27, 2021 · 2 comments
Open

Dynamic themes #336

vaadin-miki opened this issue Dec 27, 2021 · 2 comments
Assignees
@vaadin-miki
Labels
enhancement New feature or request help wanted Extra attention is needed not sure if needed The results are probably not worth the effort
Milestone
Future

Comments

@vaadin-miki
Copy link
Owner

Investigate if the hack around the lack of run-time themes (https://lumme.dev/2021/06/15/dynamic-theming-in-vaadin-flow.html) is something that can be turned into a component with events. If so, check if Carbon theme (https://github.com/anezthes/carbon-vaadin14) can be plugged in into such a solution.
@vaadin-miki vaadin-miki added this to the Next release milestone Dec 27, 2021
@vaadin-miki vaadin-miki self-assigned this Dec 27, 2021
@vaadin-miki vaadin-miki added the enhancement New feature or request label Dec 27, 2021
@vaadin-miki vaadin-miki modified the milestones: Next release, Backlog Jan 10, 2022
@vaadin-miki
Copy link
Owner Author

it seems a crucial part of the abovementioned solution is IndexHtmlRequestListener, which is not present in Vaadin 14 (it runs flow 2.X, whereas the class has been added for flow 3.X)

looking for a workaround

@vaadin-miki vaadin-miki added help wanted Extra attention is needed not sure if needed The results are probably not worth the effort labels Jan 14, 2022
@vaadin-miki
Copy link
Owner Author

not sure if this is even doable in a way I would like to see it - with themes packaged neatly into their own folders - so putting it on hold until further notice

@vaadin-miki vaadin-miki modified the milestones: Backlog, Future Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vaadin-miki vaadin-miki

Labels
enhancement New feature or request help wanted Extra attention is needed not sure if needed The results are probably not worth the effort
Projects
None yet
Milestone
Future
Development

No branches or pull requests
1 participant
@vaadin-miki