-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(flow-react): avoid Flow-React portal outlet removal conflicts #20770
base: main
Are you sure you want to change the base?
Conversation
Some routing cases in hybrid Flow layout + React view applications could produce DOM tree conflicts from Flow server-side changes and React client-side portal removal happening simultaneously. This could throw DOM `NotFoundError` in the browser. This change introduces a dedicated DOM element for React portal outlet, which allows to avoid the error. Fixes vaadin/hilla#3002
5de9f48
to
69b3861
Compare
Test Results 890 files - 269 890 suites - 269 1h 4m 34s ⏱️ - 29m 52s For more details on these failures and errors, see this check. Results for commit 6ee4e01. ± Comparison against base commit 09439d3. This pull request removes 304 tests.
♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still doesn't happen when manually running, but if I have the server open and run the hillaViewInFlowLayout
test from vaadin-platform-react-hybrid-test
it always fails with
Unexpected Application Error!
Failed to execute 'removeChild' on 'Node': The node to be removed is not a child of this node.
NotFoundError: Failed to execute 'removeChild' on 'Node': The node to be removed is not a child of this node.
at removeChildFromContainer (http://localhost:8080/VAADIN/@fs/C:/Users/.../platform/vaadin-platform-react-hybrid-test/node_modules/.vite/deps/chunk-UJKGNB4G.js?v=3c974d7f:8509:23)
```
Quality Gate passedIssues Measures |
Some routing cases in hybrid Flow layout + React view applications could produce DOM tree conflicts from Flow server-side changes and React client-side portal removal happening simultaneously. This could throw DOM
NotFoundError
in the browser. This change introduces a dedicated DOM element for React portal outlet, which allows to avoid the error.Fixes vaadin/hilla#3002