Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(TypeScript): prevent hangups of TypeScrpt tests on CI #967

Merged
merged 2 commits into from
May 22, 2023

Conversation

platosha
Copy link
Contributor

@platosha platosha commented May 19, 2023

This is a workaround for bcoe/c8#454 using Mocha's explicit exit mode.

@platosha platosha added hilla Issues related to Hilla target/2.0 labels May 19, 2023
@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (4b1de8d) 94.85% compared to head (ff7aac0) 94.85%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #967   +/-   ##
=======================================
  Coverage   94.85%   94.85%           
=======================================
  Files          14       14           
  Lines        1652     1652           
  Branches      140      140           
=======================================
  Hits         1567     1567           
  Misses         84       84           
  Partials        1        1           
Flag Coverage Δ
unittests 94.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@platosha platosha requested a review from cromoteca May 22, 2023 07:28
@sonarcloud
Copy link

sonarcloud bot commented May 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@platosha
Copy link
Contributor Author

Here's the summary of my findings on this issue: bcoe/c8#454 (comment)

@platosha platosha enabled auto-merge (squash) May 22, 2023 07:55
@platosha platosha requested a review from Lodin May 22, 2023 07:55
@platosha platosha merged commit 6bdc362 into main May 22, 2023
@platosha platosha deleted the test/force-mocha-exit branch May 22, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants