update-widgetset fails on windows if path to mvn repo has a space

[alvarezguille]

Easiest way to reproduce is to force a space in repo path with -Dmaven.repo.local=“C:/New folder”. But it also happens with default repo location when username has a space.

The issue was initially found when building a project generated with full stack started, but should be reproducible with simpler projects.

Strange thing is that update-theme theme works fine and finds 2 widgetsets, but update-widgetset finds 0 addons.

For some reason the space is shown as %20 as seen in the logs:

[INFO] --- vaadin-maven-plugin:8.1.3:update-theme (default) @ my_bakery ---
[INFO] Updating theme VAADIN\themes\apptheme
[INFO] Widgetsets found from classpath:
[INFO]  com.vaadin.board.BoardWidgetSet in jar:file:C:/New folder/com/vaadin/vaadin-board/1.0.0/vaadin-board-1.0.0.jar!/
[INFO]  com.vaadin.addon.charts.Widgetset in jar:file:C:/New folder/com/vaadin/vaadin-charts/4.0.0/vaadin-charts-4.0.0.jar!/
[INFO] Addon styles found from classpath:
[INFO]
[INFO] Search took 15ms
[INFO] Theme "VAADIN\themes\apptheme" updated
[INFO]
[INFO] --- vaadin-maven-plugin:8.1.3:update-widgetset (default) @ my_bakery ---
Error parsing jar file: file:/C:/New%20folder/com/vaadin/vaadin-spring-boot-starter/2.1.0.beta2/vaadin-spring-boot-starter-2.1.0.beta2.jar
Error parsing jar file: file:/C:/New%20folder/org/hibernate/javax/persistence/hibernate-jpa-2.1-api/1.0.0.Final/hibernate-jpa-2.1-api-1.0.0.Final.jar
Error parsing jar file: file:/C:/New%20folder/org/springframework/spring-aspects/4.3.9.RELEASE/spring-aspects-4.3.9.RELEASE.jar
Error parsing jar file: file:/C:/New%20folder/org/springframework/spring-tx/4.3.9.RELEASE/spring-tx-4.3.9.RELEASE.jar
...
Error parsing jar file: file:/C:/New%20folder/org/slf4j/jcl-over-slf4j/1.7.25/jcl-over-slf4j-1.7.25.jar
Error parsing jar file: file:/C:/New%20folder/com/vaadin/external/flute/flute/1.3.0.gg2/flute-1.3.0.gg2.jar
Error parsing jar file: file:/C:/New%20folder/org/springframework/boot/spring-boot-starter-jdbc/1.5.4.RELEASE/spring-boot-starter-jdbc-1.5.4.RELEASE.jar
Widgetsets found from classpath:

Search took 156ms
[INFO] 0 addons found.

One workaround for this problem is to change the location of local repo for one without spaces:
One option is to use -Dmaven.repo.local=newLocation, a more general workaround is to set the localRepository in your mvn settings as shown in maven.apache.org/settings.html