Enable parallel execution in rln-wasm #109
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rahulghangas
commented
Feb 1, 2023
rahulghangas
commented
- Closes Parallel execution in rln-wasm #55
|
Is this PR still draft or is it ready for review? |
|
rln-wasm tests are failing, so I guess is still in draft? Furthermore, I believe these changes has to be fully tested with all submodules that use the "parallel" feature (rln, so groth16, arkworks, etc.) and the output WASM should be tested with js-rln too to see if it is working as expected @richard-ramos |
|
Still a draft, it compiles but tests get deadlocked for some reason, I think because the pool doesn't get initialized on the client side. Will figure this out today |
oskarth
requested review from
richard-ramos
and removed request for
s1fr0 and
richard-ramos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.