Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write tests for the created EnvoyFilter on an actual cluster #1

Open
vadasambar opened this issue Jul 4, 2022 · 0 comments
Open

Write tests for the created EnvoyFilter on an actual cluster #1

vadasambar opened this issue Jul 4, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@vadasambar
Copy link
Owner

Why

  • Right now in tests we compare the EnvoyFilter resource that HttpGzip custom resource creates with the desired (correct) EnvoyFilter resource it should create.
  • It'd be better to test if the EnvoyFilter resource created by HttpGzip works as we expect by testing it out in a local cluster e.g., create a k3d cluster in the tests, expose a LoadBalancer and ping the services to see if the HttpResponse headers use gzip encoding.

Acceptance criteria

  • Tests should test the EnvoyFilter by pinging an actual service to see if gzip is enabled
@vadasambar vadasambar added the enhancement New feature or request label Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vadasambar