Skip to content

Commit

Permalink
fix: pythonpackage.yml failing on macos-13 (#2432)
Browse files Browse the repository at this point in the history
* Fix pythonpackage.yml failing on macos-13

* Trigger CI

* Back to macos-13 for python 3.8

* Back to macos-latest

* Build aarch64 linux wheels on macos-14 (M1)

* Revert

* Do not build musllinux_aarch64 wheels

* Add comment, bring back cp39+ musllinux_aarch64
  • Loading branch information
ddelange authored Sep 12, 2024
1 parent e3e1842 commit 4864874
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 3 deletions.
9 changes: 8 additions & 1 deletion .github/workflows/pythonpackage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,11 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest, windows-latest, macos-13]
os: [ubuntu-latest, windows-latest, macos-latest]
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
exclude:
- {os: windows-latest, python-version: "3.8"}
- {os: macos-latest, python-version: "3.8"}

steps:
- uses: actions/checkout@v2
Expand Down Expand Up @@ -56,6 +57,12 @@ jobs:
if: startswith(matrix.os, 'macos')
run: brew install libomp

# xcode 15.2 throws compilation errors ref https://github.com/vaexio/vaex/pull/2432
# select older xcode from the available versions on the runner ref https://github.com/actions/runner-images/blob/ff9acc6/images/macos/macos-13-Readme.md#xcode
- name: Switch to older Xcode (Mac-only)
if: startswith(matrix.os, 'macos')
run: sudo xcode-select -s "/Applications/Xcode_15.0.1.app"

- name: Copy dll (Windows-only)
if: (matrix.os == 'windows-latest')
uses: ./ci/actions/windll
Expand Down
7 changes: 5 additions & 2 deletions .github/workflows/wheel.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@ jobs:

- id: set-matrix
env:
CIBW_SKIP: pp* cp38-win*
# skipping pypy for now, cp38-win was segfaulting on CI, numpy has no wheels for cp38-musllinux_aarch64 -> build from source -> CI timeouts
CIBW_SKIP: pp* cp38-win* cp38-musllinux_aarch64
run: |
MATRIX_INCLUDE=$(
{
Expand Down Expand Up @@ -85,7 +86,9 @@ jobs:
if: runner.os == 'Linux'
uses: docker/setup-qemu-action@v3

- name: Switch to older Xcode
# xcode 15.2 throws compilation errors ref https://github.com/vaexio/vaex/pull/2432
# select older xcode from the available versions on the runner ref https://github.com/actions/runner-images/blob/ff9acc6/images/macos/macos-13-Readme.md#xcode
- name: Switch to older Xcode (Mac-only)
if: startswith(matrix.os, 'macos')
run: sudo xcode-select -s "/Applications/Xcode_15.0.1.app"

Expand Down

0 comments on commit 4864874

Please sign in to comment.