Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump numpy~=1.26.4 #2433

Closed
wants to merge 2 commits into from
Closed

Bump numpy~=1.26.4 #2433

wants to merge 2 commits into from

Conversation

ddelange
Copy link
Contributor

fix flaky timeout on master by requiring recent numpy which has wheels available for musllinux_aarch64

@EwoutH
Copy link
Contributor

EwoutH commented Sep 13, 2024

NumPy follows SPEC 0, which means Python 3.8 support got dropped in NumPy 1.25.0.

NumPy 1.24.4 is the last release that supported Python 3.8.

@maartenbreddels
Copy link
Member

And I'm not sure we should bump the dependency for all just for a build issue. Can we only do this when we build the wheel... i guess we should also build to the latest possible.

Why is it flakey btw?

@ddelange
Copy link
Contributor Author

you're right, this PR doens't make sense in the current state.

on master there is only one failing wheel build: https://github.com/vaexio/vaex/actions/runs/10835977160/job/30068700570

due to oldest-supported-numpy selecting a version of numpy for which no wheels are available. building numpy from source under QEMU takes forever, so we're hitting the builtin github actions 6 hour timeout (which can't be increased)

@ddelange
Copy link
Contributor Author

it's flaky: the scheduled run on master was successfull: https://github.com/vaexio/vaex/actions/runs/10841954610

@ddelange
Copy link
Contributor Author

we could simplify our lives if we don't add support for musllinux_aarch64 wheels in the upcoming release. thoughts? 👍 👎

@maartenbreddels
Copy link
Member

Only manylinux_aarch64 ? I'm fine with that!

@ddelange
Copy link
Contributor Author

Closing in favour of #2434

@ddelange ddelange closed this Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants