Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create PDF everytime #59

Open
minamotorin opened this issue Sep 4, 2021 · 0 comments
Open

Create PDF everytime #59

minamotorin opened this issue Sep 4, 2021 · 0 comments

Comments

@minamotorin
Copy link

minamotorin commented Sep 4, 2021 •
edited
Loading

This script create PDF every running. Is there any reason? If there are no reason, create PDF only when all links and images are fetched is good idea. Because creating PDF takes time.

The condition in python is here:

((not self.obstinatePages) and len(self.pageLinkDict) == len(downloadService.pagesFetched))

As another idea, add option to create PDF is second way. Normaly program didn't create PDF and create PDF only with option.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@minamotorin