Adding replication ability to valkey test case, changing waiter functionality for more flexibility in the future #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zackcam
force-pushed
the
unstable
branch
4 times, most recently
from
74ece05 to
18a279e
Compare
…ionality for more flexibility in the future Signed-off-by: zackcam <zackcam@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a class for replication in valkey_test_case.py as well as a simple test that checks it works as intended. In addition to this changed how waiters worked to allow more cases to be added in the future with different operators.
Due to the change in waiters the timing test in test_save_and_restore was now quicker causing it to fail so changed the position of the wait in order for the test to work again.