Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rust: Add test to reproduce the bug of timeout and ordering issue #2251

Closed
adarovadya opened this issue Sep 9, 2024 · 2 comments
Closed

Rust: Add test to reproduce the bug of timeout and ordering issue #2251

adarovadya opened this issue Sep 9, 2024 · 2 comments
Assignees
@ikolomi
Labels
backlog Issues/tasks/etc currentlly part of backlog bug Something isn't working Rust core redis-rs/glide-core matter
Milestone
1.1

Comments

@adarovadya
Copy link
Collaborator

Describe the bug

bug description - #2138

Expected Behavior

we expected that we have a test which will failed in this case

Current Behavior

we didnt know about this ordering issue

Reproduction Steps

create two commands with different response type and the first one will get timeout in the test

Possible Solution

No response

Additional Information/Context

No response

Client version used

Engine type and version

OS

Language

TypeScript

Language Version

Cluster information

No response

Logs

No response

Other information

No response
@adarovadya adarovadya added bug Something isn't working backlog Issues/tasks/etc currentlly part of backlog node Node.js wrapper labels Sep 9, 2024
@adarovadya adarovadya added this to the 1.1 milestone Sep 9, 2024
@adarovadya adarovadya self-assigned this Sep 9, 2024
@adarovadya adarovadya moved this to In Progress in Valkey-GLIDE - internal Sep 9, 2024
@ikolomi ikolomi assigned ikolomi and unassigned adarovadya Sep 16, 2024
@ikolomi ikolomi added Rust core redis-rs/glide-core matter and removed node Node.js wrapper labels Sep 16, 2024
@adarovadya adarovadya changed the title Node: Add test to reproduce the bug of timeout and ordering issue Rust: Add test to reproduce the bug of timeout and ordering issue Sep 16, 2024
@ikolomi ikolomi mentioned this issue Sep 19, 2024
Closed
@ikolomi
Copy link
Collaborator

ikolomi commented Sep 19, 2024

Trying a number of techniques did not yield the positive detection of reordering issues , nor the review of the entire data path.
Concluding no reordering can be possible due to command expiration or retries.
Decided to disable retry mechanics due to reasons described in this PR: #2330

@acarbonetto acarbonetto moved this from In Progress to Review in Valkey-GLIDE - internal Sep 21, 2024
@acarbonetto acarbonetto moved this from Review to In Progress in Valkey-GLIDE - internal Sep 21, 2024
@ikolomi
Copy link
Collaborator

ikolomi commented Sep 23, 2024

PR #2330 was aborted

@ikolomi ikolomi closed this as completed Sep 23, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Valkey-GLIDE - internal Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ikolomi ikolomi

Labels
backlog Issues/tasks/etc currentlly part of backlog bug Something isn't working Rust core redis-rs/glide-core matter
Projects
Valkey-GLIDE - internal
Status: Done
Milestone
1.1
Development

No branches or pull requests
2 participants
@adarovadya @ikolomi