Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bitpos implementation for python and node #2343

Open
shohamazon opened this issue Sep 23, 2024 · 0 comments · May be fixed by #2227 or #2256
Open

Fix bitpos implementation for python and node #2343

shohamazon opened this issue Sep 23, 2024 · 0 comments · May be fixed by #2227 or #2256
Assignees
@Yury-Fridlyand @cyip10
Labels
1_2_candidate bug Something isn't working node Node.js wrapper python Python wrapper
Milestone
1.2

Comments

@shohamazon
Copy link
Collaborator

shohamazon commented Sep 23, 2024 •
edited
Loading

  1. bitpos should use OffsetOptions (like bitcount uses)
    and should not be saparated to bitpos and bitpos iterval

  2. OffsetOptions should not allow specifying indexType but not end
@shohamazon shohamazon added python Python wrapper node Node.js wrapper labels Sep 23, 2024
@shohamazon shohamazon added this to the 1.2 milestone Sep 23, 2024
@shohamazon shohamazon added the bug Something isn't working label Sep 23, 2024
This was linked to pull requests Sep 23, 2024
Node: fix BITPOS #2227
Open
Python: bitpos valkey8 #2256
Open
@asafpamzn asafpamzn modified the milestone: 1.2 Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Yury-Fridlyand Yury-Fridlyand

@cyip10 cyip10

Labels
1_2_candidate bug Something isn't working node Node.js wrapper python Python wrapper
Projects
None yet
Milestone
1.2
Development

Successfully merging a pull request may close this issue.

Node: fix BITPOS Bit-Quill/valkey-glide
Python: bitpos valkey8 Bit-Quill/valkey-glide
4 participants
@Yury-Fridlyand @asafpamzn @shohamazon @cyip10