Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure concurrency for all CI. (#106) #1030

Merged
merged 2 commits into from
Mar 10, 2024

Conversation

Yury-Fridlyand
Copy link
Collaborator

Restore CI concurrency removed in #991.
To avoid conflicts between different CI workflows, every group name contains the wrapper name.
The purpose of this to cancel CI for a branch if it got a new commits (so new CI started).

Docs:
https://docs.github.com/en/actions/learn-github-actions/contexts
https://docs.github.com/en/actions/using-jobs/using-concurrency#example-only-cancel-in-progress-jobs-or-runs-for-the-current-workflow

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@Yury-Fridlyand Yury-Fridlyand added the CI/CD CI/CD related label Feb 22, 2024
@Yury-Fridlyand Yury-Fridlyand requested a review from a team as a code owner February 22, 2024 21:57
@shachlanAmazon
Copy link
Contributor

This change caused me to receive failure emails any time that a branch pushed twice quickly. If that can't be prevented, I don't think that this is worth the dev pain.

@Yury-Fridlyand
Copy link
Collaborator Author

Failure not a cancellation? That is weird.
Can you submit an issue to GHA?

@Yury-Fridlyand
Copy link
Collaborator Author

It was submitted a year ago: https://github.com/orgs/community/discussions/13015
The only thing I can advice is to configure email filter. The email header is different.

@barshaul
Copy link
Collaborator

Can it also be added to the CD actions (pypi-cd and npm-cd)?

@Yury-Fridlyand
Copy link
Collaborator Author

@barshaul
This change is relevant for CI running on push/PR only.

@barshaul
Copy link
Collaborator

barshaul commented Mar 4, 2024

@barshaul

This change is relevant for CI running on push/PR only.

The CD workflows are triggered by PRs

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@Yury-Fridlyand
Copy link
Collaborator Author

Added

@barshaul barshaul merged commit 542faaa into valkey-io:main Mar 10, 2024
54 of 55 checks passed
@Yury-Fridlyand Yury-Fridlyand deleted the ci/integ_yuryf_ci_concurrency branch March 18, 2024 07:44
cyip10 pushed a commit to Bit-Quill/valkey-glide that referenced this pull request Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD CI/CD related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants