Fix EOL in C# project files (#109)

[Yury-Fridlyand]

1. Minor editor config update
2. Whitespace changes:

\r\n changed to \n by

find . -type f | xargs dos2unix

[shachlanAmazon]

please no style changes without a linter rule to enforce them.

[shachlanAmazon]

What's the .editorconfig change? I can't see it, because of the linebreak change.

[Yury-Fridlyand]

Try Hide whitespaces on GH UI or use CLI

git diff -w upstream/main

diff --git a/.editorconfig b/.editorconfig
index abcc6267..49ecca62 100644
--- a/.editorconfig
+++ b/.editorconfig
@@ -7,29 +7,21 @@ insert_final_newline = true
 indent_style = space
 indent_size = 4
 tab_width = 4
+end_of_line = lf

 # Xml files
-[*.xml]
+[*.{xml,csproj}]
 indent_size = 2

-# C# files
-[*.cs]
-
-#### Core EditorConfig Options ####
-
-# Indentation and spacing
-
-# New line preferences
-end_of_line = lf
-insert_final_newline = true
-
 #### .NET Coding Conventions ####
 [*.{cs,vb}]

+# License header
+file_header_template = Copyright GLIDE-for-Redis Project Contributors - SPDX Identifier: Apache-2.0
+
 # Organize usings
 dotnet_separate_import_directive_groups = true
 dotnet_sort_system_directives_first = true
-file_header_template = unset

 # this. and Me. preferences
 dotnet_style_qualification_for_event = false:silent

[shachlanAmazon]

if you change the global editorconfig, you'll need to trigger all of the linters, and check whether this affects other languages. At least the prettier linter takes this into account.

[Yury-Fridlyand]

I reworked editorconfig - I moved C# related block (98% of the file) to csharp dir and created a symlink into benchmark/csharp to avoid duplicating a big file.
I tried to trigger all our CI in 3ece3b0 and they pass.

IMO no linters we have use editorconfig - it is an IDE recommendation ruleset for new lines, new files, new names, etc, not a requirement.
Prettier uses .editorconfig as a config by default, but it is not enabled on our project. It doesn't lint csproj files though - I tried.

[shachlanAmazon]

@avifenesh rebase over you CI change this and verify that it doesn't change the behavior of prettier.

[Sa1Gur]

BTW we could make add dotnet_analyzer_diagnostic.category-Style.severity = error to .editorconfig and it will make all codestyle rule breach as error. Not sure if it is desired outcome

[shachlanAmazon]

@Sa1Gur good idea. I don't see the value in warnings - they're just unenforced noise. Either we want the CI to enforce the linting, or we don't care about it.

[Sa1Gur]

Ok. I will raise PR then

[barshaul]

@Yury-Fridlyand can it be merged?