Java: Add expire, expireAt, pexpire, pexpireAt and ttl commands.
#1033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SanHalacogluImproving
requested review from
aaron-congo,
barshaul,
Yury-Fridlyand,
acarbonetto and
shohamazon
SanHalacogluImproving
changed the title
expire, expireAt, pexpire, pexpireAt and ttl comm…expire, expireAt, pexpire, pexpireAt and ttl commands.
shohamazon
reviewed
Feb 25, 2024
| * @param key The key to set timeout on it. | ||
| * @param seconds The timeout in seconds. | ||
| * @return <code>true</code> if the timeout was set. <code>false</code> if the timeout was not | ||
| * set. e.g. <code>key</code> doesn't exist, or operation skipped due to the provided |
There was a problem hiding this comment.
or operation skipped due to the provided arguments -> not the right place for it, its for the function with the expireOptions (for example setting a timeout on an existing key with expiry with the NX expire option)
| * @param key The key to set timeout on it. | ||
| * @param unixSeconds The timeout in an absolute Unix timestamp. | ||
| * @return <code>true</code> if the timeout was set. <code>false</code> if the timeout was not | ||
| * set. e.g. <code>key</code> doesn't exist, or operation skipped due to the provided |
There was a problem hiding this comment.
same with provided arguments
| * arguments. | ||
| * @example | ||
| * <pre> | ||
| * Boolean isSet = client.expireAt("my_key", 1672531200).get() |
There was a problem hiding this comment.
lets change that to: Instant.now().getEpochSecond() + 10L
| String key = UUID.randomUUID().toString(); | ||
|
|
||
| assertFalse(client.expireAt(key, Instant.now().getEpochSecond() + 10L).get()); | ||
| assertFalse(client.pexpireAt(key, Instant.now().getEpochSecond() + 10000L).get()); |
| CompletableFuture<Boolean> response = service.expire(key, seconds); | ||
|
|
||
| // verify | ||
| assertNotNull(response); |
There was a problem hiding this comment.
why is it different than other tests?
(assertEquals(testResponse, response);)
There was a problem hiding this comment.
Fixed.
| public void pexpire_returns_success() { | ||
| // setup | ||
| String key = "testKey"; | ||
| long milliseconds = 5L; |
There was a problem hiding this comment.
minor: change it to something with more meaning, maybe 50000
| public void pexpire_with_expireOptions_returns_success() { | ||
| // setup | ||
| String key = "testKey"; | ||
| long milliseconds = 5L; |
shohamazon
approved these changes
Feb 29, 2024
|
Please resolve the conflicts |
…ands (#96) * Java: Add expire and ttl commands Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Update commands for review comments Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Minor javadoc fix Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Spotless Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Added examples in documentation. Minor format RedisClientTest. * Spotless * Update java/client/src/main/java/glide/api/commands/GenericBaseCommands.java Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Spotless --------- Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Co-authored-by: SanHalacogluImproving <san.halacoglu@improving.com> Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
SanHalacogluImproving
force-pushed
the
java/integ_SanH_add_expire_ttl_commands
branch
from
7b81569
to
13d48b1
Compare
cyip10
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Jun 24, 2024
…ands. (valkey-io#1033) * Java: Add `expire`, `expireAt`, `pexpire`, `pexpireAt` and `ttl` commands --------- Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Co-authored-by: SanHalacogluImproving <san.halacoglu@improving.com> Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Updated based on PR comments. * Spotless and fixed ordering in TransactionTests. --------- Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com> Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.