Node - Added BLPOP command #1223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SanHalacogluImproving
approved these changes
Apr 3, 2024
Yury-Fridlyand
approved these changes
Apr 10, 2024
|
We have an issue with the current wrapper handling for blocking commands. ATM, commands are being timed out on the wrapper based on the client's request_timeout configuration, rather than on the passed timeout through the command arguments. |
acarbonetto
changed the title
|
Please pull latest commit #1283 |
alex-arzola-imp
force-pushed
the
node/integ_aarzola_add_blpop
branch
from
21ab3f0
to
21dd208
Compare
alex-arzola-imp
force-pushed
the
node/integ_aarzola_add_blpop
branch
from
6638bd8
to
16ace2e
Compare
acarbonetto
changed the title
acarbonetto
approved these changes
Apr 25, 2024
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
alex-arzola-imp
force-pushed
the
node/integ_aarzola_add_blpop
branch
from
dbd900a
to
450cc1d
Compare
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
|
@barshaul, @shohamazon |
acarbonetto
approved these changes
May 1, 2024
Yury-Fridlyand
requested review from
GumpacG,
aaron-congo,
jonathanl-bq and
tjzhang-BQ
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
…lide-for-redis into node/integ_aarzola_add_blpop Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Elen-Ghulam
approved these changes
May 6, 2024
tjzhang-BQ
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
May 8, 2024
* Node - Added BLPOP command * Addressed PR comments * Ran prettier * Added unit test and ran prettier * PR comments. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Added same-slot requirement for BLPOP and addressed PR comments * Fixed branch conflicts * Addressed PR commands * Update docs and test, fix merge errors. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Update doc. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> --------- Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com> Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
cyip10
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Jun 24, 2024
* Node - Added BLPOP command * Addressed PR comments * Ran prettier * Added unit test and ran prettier * PR comments. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Added same-slot requirement for BLPOP and addressed PR comments * Fixed branch conflicts * Addressed PR commands * Update docs and test, fix merge errors. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Update doc. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> --------- Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com> Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Added BLPOP command to the Node code
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.