Java: Add BITFIELD and BITFIELD_RO commands
#1510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GumpacG
force-pushed
the
java/integ_guiang_bitfield_ro
branch
from
d0ab6dc
to
1f7080e
Compare
aaron-congo
reviewed
May 31, 2024
java/client/src/main/java/glide/api/commands/BitmapBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/BitmapBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/BitmapBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/BitmapBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/BitmapBaseCommands.java
Outdated
Show resolved
Hide resolved
acarbonetto
reviewed
May 31, 2024
| @@ -199,6 +199,8 @@ enum RequestType { | |||
| XDel = 166; | |||
| LMove = 168; | |||
| BLMove = 169; | |||
| BitField = 170; | |||
| BitFieldReadOnly = 171; | |||
There was a problem hiding this comment.
I think we should just keep it identical to the command
Suggested change
| BitFieldReadOnly = 171; | |
| BitField_Ro = 171; |
There was a problem hiding this comment.
Not sure I agree with this, it doesn't seem java like to have camel case and underscore and ignore the acronym. Jedis names it similar for example https://javadoc.io/doc/redis.clients/jedis/4.2.3/redis/clients/jedis/commands/StringCommands.html#bitfieldReadonly-java.lang.String-java.lang.String...-.
Thoughts?
glide-core/src/request_type.rs
Outdated
| @@ -169,6 +169,8 @@ pub enum RequestType { | |||
| XDel = 166, | |||
| LMove = 168, | |||
| BLMove = 169, | |||
| BitField = 170, | |||
| BitFieldReadOnly = 171, | |||
There was a problem hiding this comment.
Suggested change
| BitFieldReadOnly = 171, | |
| BitField_Ro = 171, |
| @@ -341,6 +343,8 @@ impl From<::protobuf::EnumOrUnknown<ProtobufRequestType>> for RequestType { | |||
| ProtobufRequestType::XDel => RequestType::XDel, | |||
| ProtobufRequestType::LMove => RequestType::LMove, | |||
| ProtobufRequestType::BLMove => RequestType::BLMove, | |||
| ProtobufRequestType::BitField => RequestType::BitField, | |||
| ProtobufRequestType::BitFieldReadOnly => RequestType::BitFieldReadOnly, | |||
There was a problem hiding this comment.
Suggested change
| ProtobufRequestType::BitFieldReadOnly => RequestType::BitFieldReadOnly, | |
| ProtobufRequestType:: BitField_Ro => RequestType:: BitField_Ro, |
There was a problem hiding this comment.
The command is: bitfield_ro
We don't replace letters, for example: XDel. Not XDelete or StreamDelete.
What's different about the _ro?
| @@ -509,6 +513,8 @@ impl RequestType { | |||
| RequestType::XDel => Some(cmd("XDEL")), | |||
| RequestType::LMove => Some(cmd("LMOVE")), | |||
| RequestType::BLMove => Some(cmd("BLMOVE")), | |||
| RequestType::BitField => Some(cmd("BITFIELD")), | |||
| RequestType::BitFieldReadOnly => Some(cmd("BITFIELD_RO")), | |||
There was a problem hiding this comment.
Suggested change
| RequestType::BitFieldReadOnly => Some(cmd("BITFIELD_RO")), | |
| RequestType:: BitField_Ro => Some(cmd("BITFIELD_RO")), |
java/client/src/main/java/glide/api/models/commands/bitmap/BitFieldOptions.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/commands/bitmap/BitFieldOptions.java
Outdated
Show resolved
Hide resolved
GumpacG
force-pushed
the
java/integ_guiang_bitfield_ro
branch
from
9d35be0
to
bc28f83
Compare
aaron-congo
reviewed
Jun 3, 2024
java/client/src/main/java/glide/api/models/commands/bitmap/BitFieldOptions.java
Outdated
Show resolved
Hide resolved
aaron-congo
approved these changes
Jun 3, 2024
GumpacG
force-pushed
the
java/integ_guiang_bitfield_ro
branch
from
cf246aa
to
a579cbf
Compare
acarbonetto
approved these changes
Jun 3, 2024
Elen-Ghulam
approved these changes
Jun 3, 2024
Yury-Fridlyand
approved these changes
Jun 4, 2024
| @@ -341,6 +343,8 @@ impl From<::protobuf::EnumOrUnknown<ProtobufRequestType>> for RequestType { | |||
| ProtobufRequestType::XDel => RequestType::XDel, | |||
| ProtobufRequestType::LMove => RequestType::LMove, | |||
| ProtobufRequestType::BLMove => RequestType::BLMove, | |||
| ProtobufRequestType::BitField => RequestType::BitField, | |||
| ProtobufRequestType::BitFieldReadOnly => RequestType::BitFieldReadOnly, | |||
There was a problem hiding this comment.
TLDR
I trust you covered all possible and impossible cases
GumpacG
force-pushed
the
java/integ_guiang_bitfield_ro
branch
from
e2b0135
to
3733e22
Compare
cyip10
pushed a commit
to Bit-Quill/valkey-glide
that referenced
this pull request
Jun 24, 2024
* Java: Add `BITFIELD` and `BITFIELD_RO` command (#314) * Initial implementation for early review * Added javadocs and tests * Addressed comments * Fixed javadocs * Fixed link * Fixed javadocs * Addressed comments * Resolved conflicts * Addressed PR comments * Missed PR comment * Resolved conflicts * Addressed PR comments * Rebased * Improved import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Implements
BITFIELDandBITFILED_ROcommands in the java client.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.