Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All tests will no longer be skipped #1515

Merged
merged 2 commits into from
Jun 3, 2024
Merged

Conversation

adarovadya
Copy link
Collaborator

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@adarovadya adarovadya requested a review from a team as a code owner June 3, 2024 12:54
@barshaul
Copy link
Collaborator

barshaul commented Jun 3, 2024

@adarovadya Thanks! Can you open a PR that fixes the nodejs errors as well?

@barshaul barshaul merged commit 758aea0 into valkey-io:main Jun 3, 2024
6 of 8 checks passed
@Yury-Fridlyand Yury-Fridlyand added node Node.js wrapper testing Everything about testing labels Jun 4, 2024
cyip10 pushed a commit to Bit-Quill/valkey-glide that referenced this pull request Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
node Node.js wrapper testing Everything about testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants