Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI after repo move. #1870

Merged
merged 3 commits into from
Jul 9, 2024
Merged

Fix CI after repo move. #1870

merged 3 commits into from
Jul 9, 2024

Conversation

Yury-Fridlyand
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand commented Jul 8, 2024

Fix CI for all clients + update CD for java

Clones #1868 from a local branch - expecting GHA to find secrets and run

* Trigger CI on new upstream
* Update java client CD.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@Yury-Fridlyand
Copy link
Collaborator Author

2 CI workflow failed due to the missing fix from #1880

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@Yury-Fridlyand Yury-Fridlyand added the java issues and fixes related to the java client label Jul 8, 2024
@@ -148,6 +166,6 @@ jobs:
continue-on-error: true
uses: actions/upload-artifact@v4
with:
name: java-bundle-${{ matrix.java }}-redis-${{ matrix.redis }}-${{ matrix.host.TARGET }}
name: java-${{ matrix.host.TARGET }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is fine, but we may have multiple artefacts if we build the whole matrix

@Yury-Fridlyand Yury-Fridlyand merged commit 2392cc4 into main Jul 9, 2024
39 checks passed
@Yury-Fridlyand Yury-Fridlyand deleted the ci/update-upstream branch July 9, 2024 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD CI/CD related java issues and fixes related to the java client
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants