Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the way we check repo owner on cd workflows #1898

Merged
merged 11 commits into from
Jul 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/go.yml
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,6 @@ jobs:
run: make test

build-amazonlinux-latest:
if: github.repository_owner == 'valkey-io'
strategy:
# Run all jobs
fail-fast: false
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/java-cd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ permissions:

jobs:
start-self-hosted-runner:
if: github.repository_owner == 'valkey-io'
if: github.event.pull_request.head.repo.owner.login == 'valkey-io'
runs-on: ubuntu-latest
environment: AWS_ACTIONS
steps:
Expand All @@ -43,7 +43,7 @@ jobs:

create-binaries-to-publish:
needs: start-self-hosted-runner
if: github.repository_owner == 'valkey-io'
if: github.event.pull_request.head.repo.owner.login == 'valkey-io'
timeout-minutes: 35
env:
JAVA_VERSION: '11'
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/java.yml
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,6 @@ jobs:
java/client/build/reports/spotbugs/**

build-amazonlinux-latest:
if: github.repository_owner == 'valkey-io'
strategy:
# Run all jobs
fail-fast: false
Expand Down
7 changes: 2 additions & 5 deletions .github/workflows/npm-cd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,10 @@ permissions:

jobs:
start-self-hosted-runner:
if: github.repository_owner == 'valkey-io'
if: github.event.pull_request.head.repo.owner.login == 'valkey-io'
runs-on: ubuntu-latest
environment: AWS_ACTIONS
steps:
- run: echo $OWNER
env:
OWNER: ${{ github.repository_owner }}
- name: Checkout
uses: actions/checkout@v4
with:
Expand Down Expand Up @@ -67,7 +64,7 @@ jobs:

publish-binaries:
needs: [start-self-hosted-runner, load-platform-matrix]
if: github.repository_owner == 'valkey-io'
if: github.event.pull_request.head.repo.owner.login == 'valkey-io'
name: Publish packages to NPM
runs-on: ${{ matrix.build.RUNNER }}
container:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/pypi-cd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ jobs:


start-self-hosted-runner:
if: github.repository_owner == 'valkey-io'
if: github.event.pull_request.head.repo.owner.login == 'valkey-io'
runs-on: ubuntu-latest
environment: AWS_ACTIONS
steps:
Expand All @@ -61,7 +61,7 @@ jobs:

publish-binaries:
needs: [start-self-hosted-runner, load-platform-matrix]
if: github.repository_owner == 'valkey-io'
if: github.event.pull_request.head.repo.owner.login == 'valkey-io'
name: Publish packages to PyPi
runs-on: ${{ matrix.build.RUNNER }}
timeout-minutes: 25
Expand Down
Loading