Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix release version for java client. #1903

Merged
merged 6 commits into from
Jul 11, 2024
Merged

Fix release version for java client. #1903

merged 6 commits into from
Jul 11, 2024

Conversation

Yury-Fridlyand
Copy link
Collaborator

Unfortunately, commit 036994de296c45 was lost from v1.0 branch and java release artifacts got generated with the wrong version.

  • Fixing java artifact version
  • Adding mac runners to CD workflow

@Yury-Fridlyand
Fix release version for java client.
e370d6f 
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@Yury-Fridlyand
Add mac runners to CD.
c3369d1 
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@Yury-Fridlyand Yury-Fridlyand added java issues and fixes related to the java client CI CI/CD related labels Jul 9, 2024
@Yury-Fridlyand Yury-Fridlyand requested a review from a team as a code owner July 9, 2024 17:31
@Yury-Fridlyand
Generate sources with the release.
867c0cf 
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@Yury-Fridlyand
Strip rust lib.
8901e3d 
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@Yury-Fridlyand
Revert Strip rust lib.
9356c99 
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
barshaul
barshaul requested changes Jul 10, 2024
View reviewed changes
Copy link
Collaborator

@barshaul barshaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't merge this commit in, see my comment

@Yury-Fridlyand
Address PR comments.
9428a19 
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@Yury-Fridlyand
Copy link
Collaborator Author

Yury-Fridlyand commented Jul 10, 2024 •
edited
Loading

@barshaul updated
This is the actual CD workflow which were used yesterday to generate the release artifacts. I used another branch, so these changes weren't reflected there.

Will backport to main after merging this PR

@Yury-Fridlyand Yury-Fridlyand mentioned this pull request Jul 11, 2024
Merged
5 tasks
@barshaul barshaul merged commit 73d36d0 into valkey-io:v1.0 Jul 11, 2024
5 of 8 checks passed
@Yury-Fridlyand Yury-Fridlyand deleted the java/fix-release-version-100 branch July 19, 2024 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barshaul barshaul barshaul requested changes

@acarbonetto acarbonetto acarbonetto approved these changes

Assignees
No one assigned
Labels
CI CI/CD related java issues and fixes related to the java client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yury-Fridlyand @barshaul @acarbonetto