Go client: Adding a skeleton to create client connection and invoke SET and GET commands. #1937

janhavigupta007 · 2024-07-15T09:12:16Z

This includes changes:

Creating a client connection.
Invoking SET and GET commands.
Integration tests for connection and SET and GET commands.
Benchmarking code for SET and GET commands.

glide-core/src/request_type.rs

go/src/lib.rs

eifrah-aws

Please rebase your branch
Use the Java binding to modify remove references to Redis in the code. For example RedisClient is now named GlideClient etc. Please align the code with the other bindings

glide-core/src/protobuf/redis_request.proto

go/api/base_client.go

go/api/response_handlers.go

go/src/lib.rs

.github/workflows/go.yml

go/.gitignore

go/api/commands.go

go/api/config.go

go/api/response_handlers.go

go/api/standalone_client.go

protoc-3.20.3-linux-x86_64.zip

go/protoc-3.20.3-linux-x86_64.zip

go/integTest/shared_commands_test.go

go/src/lib.rs

go/DEVELOPER.md

go/api/base_client.go

go/api/glide_client.go

java/THIRD_PARTY_LICENSES_JAVA

node/DEVELOPER.md

go/api/base_client.go

go/api/commands.go

go/api/config_test.go

go/benchmarks/gobenchmarks.json

go/examples/main.go

go/integTest/glide_test_suite_test.go

go/integTest/shared_commands_test.go

go/src/lib.rs

Signed-off-by: Janhavi Gupta <janhavigupta@google.com>

…untu/centos Signed-off-by: Janhavi Gupta <janhavigupta@google.com>

Fixes a bug where the benchmarks were ran twice for go-redis when the -clients option was set to "all" Signed-off-by: Janhavi Gupta <janhavigupta@google.com>

Signed-off-by: Janhavi Gupta <janhavigupta@google.com>

.github/workflows/go.yml

…n and invoke set and get commands Signed-off-by: Janhavi Gupta <janhavigupta@google.com>

…_struct

janhavigupta007 requested a review from a team as a code owner July 15, 2024 09:12

Yury-Fridlyand requested changes Jul 15, 2024

View reviewed changes

glide-core/src/request_type.rs Outdated Show resolved Hide resolved

go/src/lib.rs Show resolved Hide resolved

Yury-Fridlyand added the go golang wrapper label Jul 15, 2024

eifrah-aws requested changes Jul 16, 2024

View reviewed changes

Yury-Fridlyand reviewed Jul 16, 2024

View reviewed changes

This was referenced Jul 17, 2024

Go: Implement connect Bit-Quill/valkey-glide#136

Closed

[internal review] Go: implement standalone custom command Bit-Quill/valkey-glide#152

Closed

jonathanl-bq reviewed Jul 24, 2024

View reviewed changes

go/src/lib.rs Outdated Show resolved Hide resolved

eifrah-aws reviewed Aug 1, 2024

View reviewed changes

go/DEVELOPER.md Outdated Show resolved Hide resolved

go/api/base_client.go Show resolved Hide resolved

go/api/glide_client.go Outdated Show resolved Hide resolved

java/THIRD_PARTY_LICENSES_JAVA Outdated Show resolved Hide resolved

node/DEVELOPER.md Outdated Show resolved Hide resolved

Yury-Fridlyand reviewed Aug 2, 2024

View reviewed changes

jonathanl-bq reviewed Aug 2, 2024

View reviewed changes

go/src/lib.rs Show resolved Hide resolved

janhavigupta007 force-pushed the go/command_response_struct branch 6 times, most recently from bd8b095 to e7a3714 Compare August 6, 2024 16:37

acarbonetto and others added 5 commits August 6, 2024 16:51

Go: create client connection (valkey-io#1303)

728cda0

Signed-off-by: Janhavi Gupta <janhavigupta@google.com>

Go: Implement benchmarking (valkey-io#1330)

e4b7f36

Signed-off-by: Janhavi Gupta <janhavigupta@google.com>

Update DEVELOPER.md with instructions to extend LD_LIBRARY_PATH on ub…

e23a546

…untu/centos Signed-off-by: Janhavi Gupta <janhavigupta@google.com>

Go: Fix bug with -clients=all setting (valkey-io#1339)

6dbbc51

Fixes a bug where the benchmarks were ran twice for go-redis when the -clients option was set to "all" Signed-off-by: Janhavi Gupta <janhavigupta@google.com>

Go: update protobuf version to address dependabot alert (valkey-io#1352)

8325608

Signed-off-by: Janhavi Gupta <janhavigupta@google.com>

janhavigupta007 force-pushed the go/command_response_struct branch from bfb06ea to 62380c1 Compare August 6, 2024 16:53

eifrah-aws self-requested a review August 6, 2024 19:16

Yury-Fridlyand approved these changes Aug 6, 2024

View reviewed changes

.github/workflows/go.yml Outdated Show resolved Hide resolved

eifrah-aws approved these changes Aug 7, 2024

View reviewed changes

janhavigupta007 force-pushed the go/command_response_struct branch from f740afb to ca3bf25 Compare August 19, 2024 09:22

Go client: Preparing the skeleton code to create the client connectio…

9b7bbc4

…n and invoke set and get commands Signed-off-by: Janhavi Gupta <janhavigupta@google.com>

janhavigupta007 force-pushed the go/command_response_struct branch from fe6914f to 9b7bbc4 Compare August 19, 2024 09:37

Merge remote-tracking branch 'upstream/main' into go/command_response…

80f7a69

…_struct

eifrah-aws self-requested a review August 19, 2024 15:12

eifrah-aws approved these changes Aug 19, 2024

View reviewed changes

eifrah-aws merged commit 322d8d7 into valkey-io:main Aug 19, 2024
8 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Go client: Adding a skeleton to create client connection and invoke SET and GET commands. #1937

Go client: Adding a skeleton to create client connection and invoke SET and GET commands. #1937

janhavigupta007 commented Jul 15, 2024

eifrah-aws left a comment •

edited

Loading

Go client: Adding a skeleton to create client connection and invoke SET and GET commands. #1937

Go client: Adding a skeleton to create client connection and invoke SET and GET commands. #1937

Conversation

janhavigupta007 commented Jul 15, 2024

eifrah-aws left a comment • edited Loading

Choose a reason for hiding this comment

eifrah-aws left a comment •

edited

Loading