Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java: Update workflow to zip bundle files and use build-matrix.json #2128

Merged
merged 6 commits into from
Sep 9, 2024

Conversation

GumpacG
Copy link
Collaborator

@GumpacG GumpacG commented Aug 13, 2024

Issue

Completes: #2000 and #2040

Instructions

The Maven Release can be triggered by creating a release tag on GitHub or manually running the Java Prepare Deployment workflow. Once the workflow is running, a member of AWS_ACTIONS will be required to approve twice:

  1. To publish the deployment, and
  2. To publish the release on Maven Central.

Release Trigger

Create a release with tag v*.. (e.g. v1.2.0, or v1.3.0-rc2 for a release candidate) which will determine the version of the release.
Screenshot 2024-09-05 at 8 28 56 AM

Workflow Trigger

Manually run the workflow by going to https://github.com/valkey-io/valkey-glide/actions/workflows/java-cd.yml and specifying the version and checking the box for publishing.
Screenshot 2024-09-05 at 8 34 49 AM

Troubleshooting

If the last job for publishing the release to Maven Central fails, an admin can manually publish to Maven Central.

  1. Log in to Maven Central.
  2. Select the deployment with the same Deployment ID that is printed in the job "Publish to Maven Central".
  3. Click “Publish”.
Screenshot 2024-09-05 at 8 44 59 AM Screenshot 2024-09-05 at 8 47 17 AM

@Yury-Fridlyand Yury-Fridlyand added java issues and fixes related to the java client CI/CD CI/CD related labels Aug 13, 2024
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran CD on this branch and see that everything is packed properly.
Thanks!

.github/workflows/java-cd.yml Outdated Show resolved Hide resolved
Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
.github/workflows/java-cd.yml Show resolved Hide resolved
.github/workflows/java-cd.yml Outdated Show resolved Hide resolved
.github/workflows/java-cd.yml Outdated Show resolved Hide resolved
.github/workflows/java-cd.yml Outdated Show resolved Hide resolved
java/benchmarks/build.gradle Show resolved Hide resolved
Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
@GumpacG GumpacG merged commit 7d0ddf5 into main Sep 9, 2024
58 checks passed
@GumpacG GumpacG deleted the CI/maven_automation branch September 9, 2024 15:11
janhavigupta007 pushed a commit to janhavigupta007/glide-for-redis that referenced this pull request Sep 11, 2024
…alkey-io#2128)

* Add Maven release automation workflow

Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD CI/CD related java issues and fixes related to the java client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automate Maven Publishing
5 participants