-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java: Update workflow to zip bundle files and use build-matrix.json #2128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GumpacG
commented
Aug 13, 2024
Yury-Fridlyand
added
java
issues and fixes related to the java client
CI/CD
CI/CD related
labels
Aug 13, 2024
Yury-Fridlyand
approved these changes
Aug 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran CD on this branch and see that everything is packed properly.
Thanks!
jonathanl-bq
approved these changes
Aug 15, 2024
Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
GumpacG
force-pushed
the
CI/maven_automation
branch
from
September 6, 2024 17:02
0036c3c
to
ec35824
Compare
Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
GumpacG
commented
Sep 7, 2024
Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
eifrah-aws
approved these changes
Sep 8, 2024
janhavigupta007
pushed a commit
to janhavigupta007/glide-for-redis
that referenced
this pull request
Sep 11, 2024
…alkey-io#2128) * Add Maven release automation workflow Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Completes: #2000 and #2040
Instructions
The Maven Release can be triggered by creating a release tag on GitHub or manually running the Java Prepare Deployment workflow. Once the workflow is running, a member of AWS_ACTIONS will be required to approve twice:
Release Trigger
Create a release with tag v*.. (e.g.
v1.2.0
, orv1.3.0-rc2
for a release candidate) which will determine the version of the release.Workflow Trigger
Manually run the workflow by going to https://github.com/valkey-io/valkey-glide/actions/workflows/java-cd.yml and specifying the version and checking the box for publishing.
Troubleshooting
If the last job for publishing the release to Maven Central fails, an admin can manually publish to Maven Central.