Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java: Script Commands #2261

Merged
merged 8 commits into from
Sep 13, 2024
Merged

Java: Script Commands #2261

merged 8 commits into from
Sep 13, 2024

Conversation

tjzhang-BQ
Copy link
Collaborator

@tjzhang-BQ tjzhang-BQ commented Sep 10, 2024 •
edited
Loading

PR implementing Script FLUSH, Script EXISTS and SCRIPT KILL in Java

TODO List:

  • Changelog
  • Adding submitScript variant with Route argument
  • Adding InvokeScript APIs with Route argument and tests
  • Adding SCRIPT EXISTS
  • Adding SCRIPT FLUSH
  • Adding SCRIPT KILL

@tjzhang-BQ tjzhang-BQ added the java issues and fixes related to the java client label Sep 10, 2024
@tjzhang-BQ tjzhang-BQ force-pushed the java/VALKEY-188-script-exists branch 2 times, most recently from 2719b0b to 0bd59c5 Compare September 11, 2024 01:19
Yury-Fridlyand
Yury-Fridlyand reviewed Sep 11, 2024
View reviewed changes
java/client/src/main/java/glide/api/commands/ScriptingAndFunctionsBaseCommands.java Show resolved Hide resolved
java/client/src/main/java/glide/api/commands/ScriptingAndFunctionsBaseCommands.java Outdated Show resolved Hide resolved
java/client/src/main/java/glide/api/commands/ScriptingAndFunctionsBaseCommands.java Outdated Show resolved Hide resolved
java/client/src/main/java/glide/api/commands/ScriptingAndFunctionsBaseCommands.java Outdated Show resolved Hide resolved
java/client/src/main/java/glide/api/commands/ScriptingAndFunctionsClusterCommands.java Outdated Show resolved Hide resolved
java/integTest/src/test/java/glide/SharedCommandTests.java Outdated Show resolved Hide resolved
java/integTest/src/test/java/glide/SharedCommandTests.java Outdated Show resolved Hide resolved
java/integTest/src/test/java/glide/SharedCommandTests.java Outdated Show resolved Hide resolved
java/integTest/src/test/java/glide/TestUtilities.java Outdated Show resolved Hide resolved
java/integTest/src/test/java/glide/TestUtilities.java Outdated Show resolved Hide resolved
@Yury-Fridlyand
Copy link
Collaborator

Keep in mind #2277 - testing script on replica may fail

@tjzhang-BQ tjzhang-BQ marked this pull request as ready for review September 12, 2024 00:16
@tjzhang-BQ tjzhang-BQ requested a review from a team as a code owner September 12, 2024 00:16
@tjzhang-BQ tjzhang-BQ force-pushed the java/VALKEY-188-script-exists branch 2 times, most recently from e189b15 to 2ea2850 Compare September 12, 2024 01:40
@Yury-Fridlyand Yury-Fridlyand added the breaking breaking changes label Sep 12, 2024
Yury-Fridlyand
Yury-Fridlyand reviewed Sep 12, 2024
View reviewed changes
java/client/build.gradle Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
java/client/src/main/java/glide/api/GlideClient.java Outdated Show resolved Hide resolved
java/client/src/main/java/glide/api/GlideClusterClient.java Outdated Show resolved Hide resolved
java/client/src/main/java/glide/api/commands/ScriptingAndFunctionsClusterCommands.java Show resolved Hide resolved
java/client/src/main/java/glide/api/commands/ScriptingAndFunctionsClusterCommands.java Outdated Show resolved Hide resolved
java/client/src/main/java/glide/api/commands/ScriptingAndFunctionsClusterCommands.java Outdated Show resolved Hide resolved
java/integTest/src/test/java/glide/standalone/CommandTests.java Outdated Show resolved Hide resolved
java/integTest/src/test/java/glide/cluster/CommandTests.java Outdated Show resolved Hide resolved
java/integTest/src/test/java/glide/cluster/CommandTests.java Outdated Show resolved Hide resolved
TJ Zhang added 5 commits September 12, 2024 12:52
Java: Script Commands
697a102 
Signed-off-by: TJ Zhang <tj.zhang@improving.com>
Removing ScriptOptions and refactoring invokeScript APIs
e7938f2 
Signed-off-by: TJ Zhang <tj.zhang@improving.com>
Revert "Removing ScriptOptions and refactoring invokeScript APIs"
01e7a61 
This reverts commit 149f415.

Signed-off-by: TJ Zhang <tj.zhang@improving.com>
add ScripArgOptions for the cluster client
5a46a00 
Signed-off-by: TJ Zhang <tj.zhang@improving.com>
fixing conflict resolving changes
3038c53 
Signed-off-by: TJ Zhang <tj.zhang@improving.com>
doc fix
338d059 
Signed-off-by: TJ Zhang <tj.zhang@improving.com>
@tjzhang-BQ tjzhang-BQ removed the breaking breaking changes label Sep 12, 2024
address comments
5700cc8 
Signed-off-by: TJ Zhang <tj.zhang@improving.com>
removing commented out code
06619af 
Signed-off-by: TJ Zhang <tj.zhang@improving.com>
@tjzhang-BQ tjzhang-BQ merged commit 3092db4 into valkey-io:main Sep 13, 2024
13 checks passed
@tjzhang-BQ tjzhang-BQ deleted the java/VALKEY-188-script-exists branch September 13, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yipin-chen yipin-chen yipin-chen approved these changes

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand approved these changes

Assignees
No one assigned
Labels
java issues and fixes related to the java client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tjzhang-BQ @Yury-Fridlyand @yipin-chen