Java: Add PUBSUB SHARDCHANNELS command #2265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
java/client/src/main/java/glide/api/commands/PubSubClusterCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/PubSubClusterCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/PubSubClusterCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/PubSubClusterCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/PubSubClusterCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/ClusterTransaction.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/ClusterTransaction.java
Outdated
Show resolved
Hide resolved
jamesx-improving
force-pushed
the
java/jamesx-pubsub-shardchannels
branch
from
045ec2f
to
7842824
Compare
yipin-chen
approved these changes
Sep 11, 2024
jamesx-improving
force-pushed
the
java/jamesx-pubsub-shardchannels
branch
2 times, most recently
from
5d4dec3
to
bad2a3d
Compare
acarbonetto
approved these changes
Sep 11, 2024
| GlideClusterClient client = (GlideClusterClient) createClient(false); | ||
| assertEquals(0, client.pubsubChannels().get().length); | ||
| assertEquals(0, client.pubsubChannelsBinary().get().length); | ||
| assertEquals(0, client.pubsubChannels("**").get().length); |
There was a problem hiding this comment.
"**" is not defined anywhere. Can you include a comment what you're doing here?
There was a problem hiding this comment.
Borrowed from PubSubTests#pubsub_channels(), but
- it's just a matching pattern, probably should use
*instead of**; - should use
pubsubShardChannelsinstead ofpubsubChannels, as we are testing it.
Will fix these 2
Signed-off-by: James Xin <james.xin@improving.com>
Signed-off-by: James Xin <james.xin@improving.com>
Signed-off-by: James Xin <james.xin@improving.com>
Signed-off-by: James Xin <james.xin@improving.com>
jamesx-improving
force-pushed
the
java/jamesx-pubsub-shardchannels
branch
from
f78ff19
to
96a6efa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented PUBSUB SHARDCHANNELS command in Java.